Establish code style and fix errors in existing codebase #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run ESLint automatic fixes on all remaining JavaScript files
jdtzmn
force-pushed
the
jacob/code-style
branch
3 times, most recently
from
f72a073
to
9c11304
Compare
* Remove `MultisigTransaction` overrides that treat non-payment transactions differently * Add new transaction fields to multisig blobs found in tests and re-sign comparison blobs where needed * Verify read-only methods on `Transaction` work for `MultisigTransaction`s * Override inherited `Transaction` methods that mutate multisig transactions to throw an error * Override `signTxn` on `MultisigTransaction` to throw an error
jdtzmn
force-pushed
the
jacob/code-style
branch
from
9c11304
to
3550742
Compare
* Add TypeScript extension to `lint-staged` config file * Fix Compile class bug that was introduced during linter fixes
jasonpaulos
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of changes to help ensure and maintain a consistent code style:
package.jsonfor linting and formattingCloses #285.