This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: avoid query when components are destroyed #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Nov 12, 2017
| @@ -17,6 +17,8 @@ const addFacet = jest.fn(); | |||
| const searchStore = { | |||
| getFacetValues, | |||
| addFacet, | |||
| stop: () => {}, | |||
There was a problem hiding this comment.
can you jest.fn these so you test they get called correctly?
There was a problem hiding this comment.
just testing they got called adds nothing we would need to test they got called in order.
|
can you fix the conflict @rayrutjes ? |
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…ore-before-removing-facets fix: avoid query when components are destroyed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #357