Merge pull request algolia/vue-instantsearch#359 from algolia/stop-st…

…ore-before-removing-facets fix: avoid query when components are destroyed
algolia · Nov 15, 2017 · 35f14fa · 35f14fa
2 parents 4a6a893 + 533658f
commit 35f14fa
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 0 deletions.
diff --git a/packages/vue-instantsearch/src/components/Menu.vue b/packages/vue-instantsearch/src/components/Menu.vue
@@ -85,7 +85,9 @@ export default {
   },
 
   destroyed() {
+    this.searchStore.stop();
     this.searchStore.removeFacet(this.attribute);
+    this.searchStore.start();
   },
 };
 </script>
diff --git a/packages/vue-instantsearch/src/components/RangeInput.vue b/packages/vue-instantsearch/src/components/RangeInput.vue
@@ -111,7 +111,9 @@ export default {
   },
 
   destroyed() {
+    this.searchStore.stop();
     this.searchStore.removeFacet(this.attributeName);
+    this.searchStore.start();
   },
 
   computed: {

diff --git a/packages/vue-instantsearch/src/components/Rating.vue b/packages/vue-instantsearch/src/components/Rating.vue
@@ -56,7 +56,9 @@ export default {
     this.searchStore.addFacet(this.attributeName, FACET_OR);
   },
   destroyed() {
+    this.searchStore.stop();
     this.searchStore.removeFacet(this.attributeName);
+    this.searchStore.start();
   },
   computed: {
     show() {

diff --git a/packages/vue-instantsearch/src/components/RefinementList.vue b/packages/vue-instantsearch/src/components/RefinementList.vue
@@ -63,7 +63,9 @@ export default {
     this.searchStore.addFacet(this.attributeName, this.operator);
   },
   destroyed() {
+    this.searchStore.stop();
     this.searchStore.removeFacet(this.attributeName);
+    this.searchStore.start();
   },
   computed: {
     facetValues() {

diff --git a/packages/vue-instantsearch/src/components/TreeMenu.vue b/packages/vue-instantsearch/src/components/TreeMenu.vue
@@ -43,7 +43,9 @@ export default {
     );
   },
   destroyed() {
+    this.searchStore.stop();
     this.searchStore.removeFacet(this.attribute);
+    this.searchStore.start();
   },
   computed: {
     facetValues() {

diff --git a/packages/vue-instantsearch/src/components/__tests__/menu-tree.js b/packages/vue-instantsearch/src/components/__tests__/menu-tree.js
@@ -36,6 +36,8 @@ const addFacet = jest.fn();
 const searchStore = {
   getFacetValues,
   addFacet,
+  stop: () => {},
+  start: () => {},
 };
 
 test('renders proper HTML', () => {

diff --git a/packages/vue-instantsearch/src/components/__tests__/refinement-list.js b/packages/vue-instantsearch/src/components/__tests__/refinement-list.js
@@ -17,6 +17,8 @@ const addFacet = jest.fn();
 const searchStore = {
   getFacetValues,
   addFacet,
+  stop: () => {},
+  start: () => {},
 };
 
 test('renders proper HTML', () => {