Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SearchBox) add role=search to the form #2046

Merged
merged 1 commit into from
Mar 15, 2017
Merged

feat(SearchBox) add role=search to the form #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-instantsearch/src/components/SearchBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ class SearchBox extends Component {
onReset={this.onReset}
{...cx('root')}
action=""
role="search"
>
<svg xmlns="http://www.w3.org/2000/svg" style={{display: 'none'}}>
<symbol xmlns="http://www.w3.org/2000/svg" id="sbx-icon-search-13" viewBox="0 0 40 40">
Expand Down
3 changes: 3 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/Menu.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ exports[`Menu Menu with search inside items but no search results 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -173,6 +174,7 @@ exports[`Menu Menu with search inside items with search results 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -289,6 +291,7 @@ exports[`Menu applies translations 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down
3 changes: 3 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/RefinementList.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ exports[`RefinementList applies translations 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -263,6 +264,7 @@ exports[`RefinementList refinement list with search inside items but no search r
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -440,6 +442,7 @@ exports[`RefinementList refinement list with search inside items with search res
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down
7 changes: 7 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/SearchBox.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ exports[`SearchBox applies its default props 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -92,6 +93,7 @@ exports[`SearchBox lets you customize its theme 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -177,6 +179,7 @@ exports[`SearchBox lets you customize its translations 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -262,6 +265,7 @@ exports[`SearchBox lets you give custom components for reset and submit 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -343,6 +347,7 @@ exports[`SearchBox transfers the autoFocus prop to the underlying input element
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -428,6 +433,7 @@ exports[`SearchBox treats its query prop as its input value 1`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down Expand Up @@ -513,6 +519,7 @@ exports[`SearchBox treats its query prop as its input value 2`] = `
noValidate={true}
onReset={[Function]}
onSubmit={[Function]}
role="search"
>
<svg
style={
Expand Down