feat(SearchBox) add role=search to the form #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps for screenreaders, and is valid html5 since december 2015. Before then it was working, but not valid. see also w3c/html-aria#18
iam4x
approved these changes
Mar 13, 2017
Haroenv
added a commit
that referenced
this pull request
Mar 20, 2017
<a name="3.2.2-beta0"></a> ## [3.2.2-beta0](v3.2.1...v3.2.2-beta0) (2017-03-20) ### Bug Fixes * **InfiniteHits:** provide translation key for `Load More` (#2048) ([6130bf2](6130bf2)) * **SearchBox:** better mobile behaviour by default ([ea968b3](ea968b3)) * **example:** link to instantsearch/react (#2007) ([5e674cd](5e674cd)) * **recipes:** react router v4 ([de673bf](de673bf)) ### Features * **SearchBox:** add role=search to the form (#2046) ([d1e90f3](d1e90f3)) * **SearchBox:** allow custom reset and submit components (#1991) ([cd303d7](cd303d7)) * **searchBox:** add event handling ([e267ab6](e267ab6)), closes [#2017](#2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What project are you opening a pull request for?
Summary
Add a
role=searchto the form of the searchbox.This helps for screenreaders, and is valid html5 since december 2015. Before then it was working, but not valid. see also w3c/html-aria#18
Result
Some screen readers will read our search input as
search form: 3 inputs. Others will still sayform: 3 inputs.