Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master forked repository #6

Merged
merged 4 commits into from
May 15, 2020
Merged

Commits on May 14, 2020

  1. Dyn 2560 models folder2 (#10640)

    * DYN-2560 - Increase the code coverage: DynamoCore/Models
    
    Second Part
    I added some test cases for the RecordableCommands class
    
    * DYN-2560 - Increase the code coverage: DynamoCore/Models 2
    
    DYN-2560 - Increase the code coverage: DynamoCore/Models
    I created several test cases for the next clases inside the RecordableCommands.cs file:
    
    RecordableCommands.
    OpenFileCommand
    PausePlaybackCommand
    
    * DYN-2560 - Increase the code coverage: DynamoCore/Models 2
    
    I added nunit test method for the next classes:
    
    - CreateAndConnectNodeCommand
    - CreateCustomNodeCommand
    - CreateNodeCommand
    - CreateNoteCommand
    - CreateProxyNodeCommand
    - ForceRunCancelCommand
    - GroupModelCommand
    - ModelEventCommand
    - MutateTestCommand
    - OpenFileCommand
    - PausePlaybackCommand
    - PresetCommand
    - RecordableCommands
    - SelectModelCommand
    - UndoRedoCommand
    - UpdateModelValueCommand
    
    * DYN-2560 - DynamoCore/Models 2 - Code Review
    
    Some fixes in code comments that were reported during code review
    RobertGlobant20 authored May 14, 2020
    Configuration menu
    Copy the full SHA
    e9ca9b0 View commit details
    Browse the repository at this point in the history
  2. Increase coverage of the Updates folder (#10648)

    * Add a test for the CrashPromptArgs class
    
    * Update DynamoCoreTests.csproj
    
    * Added NotificationObject tests
    
    * Updated the test, NotificationObject coverage at 100%
    
    * Changed some access modifiers
    
    * Added coverage for Updates/BinaryVersion
    
    * Added comments and fixed names
    
    * Added asserts for happy path, changed namespace and deleted a console function
    
    * Removed using
    
    * Revert "Removed using"
    
    This reverts commit 022823d.
    
    * Removed a change that should not be there
    
    * Added coverage for Updates folder
    
    * Added more tests for UpdateManager.cs
    
    * Update UpdatesTests.cs
    
    Corrections from the PR review
    byorda-glb authored May 14, 2020
    Configuration menu
    Copy the full SHA
    b6ef6a7 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Code Smells [Part I] (#10652)

    * Initial Commit
    
    * Use string builder!!
    
    * CleanUps
    
    * Some more cleanups
    
    * Some more smells
    
    * spelling
    
    * Remove unnecessary public exposure
    QilongTang authored May 15, 2020
    Configuration menu
    Copy the full SHA
    2c81c3c View commit details
    Browse the repository at this point in the history
  2. [DYN-2680] Write logs to std out instead of creating new files for ea…

    …ch test. (#10651)
    
    * Write logs to std out instead of creating new files for each test.
    
    This is to avoid storing these large number of logs on the VM which is affecting its performance over time.
    
    * Fix for API break change.
    
    * Fixing the failing tests.
    
    These tests verify that the logs are written to dynamo console and to a file. When we changed the behaviour to write the logs to std out in test mode, there were failing. Fixed them accordingly.
    
    * Avoid the stream writer object, no longer needed.
    reddyashish authored May 15, 2020
    Configuration menu
    Copy the full SHA
    888face View commit details
    Browse the repository at this point in the history