Increase coverage of the Updates folder #10648
Conversation
|
|
||
| [Test] | ||
| [Category("UnitTests")] | ||
| public void CheckNewerDailyBuildTest() |
There was a problem hiding this comment.
Can we rename this test? This name is misleading as it seems it actually check newer daily builds
There was a problem hiding this comment.
Done, I consolidated the tests for the properties and it's now called UpdateManagerConfigurationPropertiesTest
| #region UpdateRequest | ||
| [Test] | ||
| [Category("UnitTests")] | ||
| public void UpdateRequest_ConstructorTest() |
There was a problem hiding this comment.
Let's not use underscore in test name
There was a problem hiding this comment.
Removed the underscore
| { | ||
| var lookup = new DynamoLookupChildTest(); | ||
|
|
||
| Assert.IsNull(lookup.LatestProduct); |
There was a problem hiding this comment.
Can you explain or comment here why it would be null?
There was a problem hiding this comment.
Added a comment regarding this. It is related to the implementation of GetDynamoInstallLocations in my test class.
|
|
||
| [Test] | ||
| [Category("UnitTests")] | ||
| public void UpdateManagerConfiguration_SaveTest() |
There was a problem hiding this comment.
Please dont use underscore, I think out team are trying to get rid of this coding style recently
There was a problem hiding this comment.
Removed the underscore
Corrections from the PR review
|
@byorda-glb Thanks, looks good to me! |
Purpose
Increase the tests coverage of the Updates folder
Declarations
Check these if you believe they are true
*.resxfilesReviewers
Aaron Tang
Michael Kisrchner
FYIs
Alfredo Pozo