Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render for kustomize #1

Merged
merged 408 commits into from
Jan 22, 2020
Merged

Add render for kustomize #1

merged 408 commits into from
Jan 22, 2020

Conversation

arminbuerkle
Copy link
Collaborator

@arminbuerkle arminbuerkle commented Oct 22, 2019

Relates to GoogleContainerTools#1937 and GoogleContainerTools#2957 for kustomize.

Description

User facing changes
Implements the render command for kustomize.

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference. (Not needed?)
  • Adds integration tests if needed. (Not needed?)

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

- Implement `skaffold render` for `kustomize` deployer

@arminbuerkle arminbuerkle force-pushed the add-render-to-kustomize branch 2 times, most recently from f908b60 to d35d3ae Compare October 23, 2019 07:09
tejal29 and others added 28 commits November 5, 2019 09:33
…_docs

[docs, API] control api + swagger ui for http api
…ig_version

[docs] change config version to v1
…dpacks

[docs] update buildpacks tutorial to custom builder
…n_mention

[docs] skaffold run docs in Continuous Delivery pipeline
…e-unique-names

init --analyze should return unique image names
…econfig-kubectl-helm

Prepare kubectl and helm deployers for `--kubeconfig` flag
…oogleContainerTools#3180)

* Right steps for secret creation

* Add pipeline run

* fix formatting
dgageot and others added 19 commits November 28, 2019 21:27
* Use simpler assertions

Signed-off-by: David Gageot <[email protected]>

* Add CheckTrue and CheckFalse

Signed-off-by: David Gageot <[email protected]>

* Add CheckNil and CheckNotNil

Signed-off-by: David Gageot <[email protected]>

* Add CheckEmpty

Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Allow for future extension with more supported builders like
jib, which is expected to produce a syncMap
…s/change-order-syncmap

Change SyncMap supported types check style
* Support new kind naming scheme

Signed-off-by: David Gageot <[email protected]>

* Load images into the proper kind cluster

Signed-off-by: David Gageot <[email protected]>

* Feedback 

Signed-off-by: David Gageot <[email protected]>

* Update local cluster doc

Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@arminbuerkle arminbuerkle force-pushed the add-render-to-kustomize branch from 5daa2e0 to 387829f Compare December 6, 2019 10:34
@arminbuerkle arminbuerkle force-pushed the add-render-to-kustomize branch from 387829f to ce818aa Compare December 10, 2019 09:52
Signed-off-by: Armin Buerkle <[email protected]>
@arminbuerkle arminbuerkle merged commit df171be into master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.