Fix missing deploy event handlers in kustomize render

Signed-off-by: Armin Buerkle <[email protected]>

pkg/skaffold/deploy/kustomize.go

@@ -98,18 +98,18 @@ func (k *KustomizeDeployer) Labels() map[string]string {
 
 // Deploy runs `kubectl apply` on the manifest generated by kustomize.
 func (k *KustomizeDeployer) Deploy(ctx context.Context, out io.Writer, builds []build.Artifact, labellers []Labeller) *Result {
+	event.DeployInProgress()
 	manifests, err := k.renderManifests(ctx, out, builds, labellers)
 	if err != nil {
 		event.DeployFailed(err)
 		return NewDeployErrorResult(err)
 	}
 
 	if len(manifests) == 0 {
+		event.DeployComplete()
 		return NewDeploySuccessResult(nil)
 	}
 
-	event.DeployInProgress()
-
 	namespaces, err := manifests.CollectNamespaces()
 	if err != nil {
 		event.DeployInfoEvent(errors.Wrap(err, "could not fetch deployed resource namespace."+
@@ -193,7 +193,11 @@ func (k *KustomizeDeployer) Render(ctx context.Context, out io.Writer, builds []
 		manifestOut = bufio.NewWriter(f)
 	}
 
-	fmt.Fprintln(manifestOut, manifests.String())
+	for _, m := range manifests {
+		if _, err := fmt.Fprintln(manifestOut, string(m)); err != nil {
+			return errors.Wrap(err, "writing manifests")
+		}
+	}
 	return nil
 }
 

pkg/skaffold/deploy/kustomize_test.go

@@ -433,6 +433,7 @@ spec:
     name: image1
   - image: gcr.io/project/image2:tag2
     name: image2
+
 `,
 		},
 	}