-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support cpp parser #134
base: main
Are you sure you want to change the base?
Conversation
Whoops. |
ffff80f
to
9dd1b5a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 86.58% 86.47% -0.11%
==========================================
Files 32 33 +1
Lines 1975 2019 +44
==========================================
+ Hits 1710 1746 +36
- Misses 265 273 +8 ☔ View full report in Codecov by Sentry. |
1417869
to
12accc0
Compare
#116 merged 🎉 Thanks again for your contribution! Feel free to rebase this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is a draft, but left some comments already!
README.md
Outdated
|
||
Try to rename a class: | ||
|
||
```cpp file=example.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you can find a more creative example (and file name) 😄 An operation like "rename class" can already be performed very well using IDEs. srgn
is more meant for things IDEs, sed
etc. cannot already easily perform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to make a more useful example. I did the best I could 😆
tests/langs/cpp/base.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm not familiar with C++. Feel free to go wild here. In all the other base
files, I tried to put literally every single component the respective languages offer. You can for example take base.py
, and hand it together with a C++ grammar definition to an LLM and ask it for a similar file, but for C++.
The reason as much as possible should be covered is to just have maximum confidence in terms of test coverage, and true/false positive matches. It guards against regressions in tree-sitter.
This is not a must-have though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the example: the example was generated by LLM. I'm not sure it's a complete set of cpp features (I'm more specialized in C language) =).
47937db
to
fa37d1c
Compare
fa37d1c
to
b8be840
Compare
Thank you very much! The revised example for the README looks good, at least like something you might not find in IDEs. Let me know when you're ready to move the PR out of draft. |
I think it is better to merge this PR after #144. After that I will fix the conflicts myself. And so maybe I'll come up with a more useful example :). |
Hi @Mephistophiles ! #144 was split off into #151 , which is now merged into And for the example you now have, I like it! |
No description provided.