-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support c language #116
Add support c language #116
Conversation
This looks fantastic, appreciate the work! I’ll take a closer look soon but on first glance it looks great. Two notes:
|
c56029a
to
552a53d
Compare
Hi! Thanks for the review!
Hmm, I have the same formatting on cargo-fmt 1.83. I'll look a little later to see why it doesn't format for me.
I'd like to use the latest version of tree-sitter-c, but it requires tree-sitter 0.23. |
I pushed a change ( e847d37 ) that might address the CI failure at https://github.com/alexpovel/srgn/actions/runs/10971586945/job/30467773900?pr=116 in this PR. But no idea what's wrong there... I'm looking into bumping tree-sitter versions. Not sure if tree-sitter/tree-sitter#3069 introduced changes I need to respect here. But nothing for you to worry about. |
4eb8b08
to
4f603ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 86.68% 86.57% -0.11%
==========================================
Files 31 32 +1
Lines 1937 1974 +37
==========================================
+ Hits 1679 1709 +30
- Misses 258 265 +7 ☔ View full report in Codecov by Sentry. |
Hi! I rebase my branch. I hope CI won't crash now =). |
4f603ee
to
d2b4f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mephistophiles , I'd be interested in your feedback. How was working on this for you? Adding support for a new language is not documented. Were there things you stumbled over (documentation, automation, ...)?
d2b4f8c
to
1178737
Compare
@alexpovel, When adding support for the C language, I relied on the comparison of how support was implemented for other languages. So, I didn't encounter any particular problems. Regarding automation with Regarding tests: do you think it is possible to automate the launch of tests for each prepared query language? This would allow updating test files (base files) in time. And another small question for the insta snapshot engine (I haven't worked with it much), is it possible to somehow detect old snapshot files that are no longer used? It happened to me that when renaming a prepared query, old files remained in staged, only rm -rf base.c_* helped =). |
Oh, |
Thanks for your feedback! Regarding your points:
|
No description provided.