Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS 13 Dark Mode #168

Closed
DK-Web opened this issue Sep 21, 2019 · 7 comments · Fixed by #170
Closed

IOS 13 Dark Mode #168

DK-Web opened this issue Sep 21, 2019 · 7 comments · Fixed by #170

Comments

@DK-Web
Copy link

DK-Web commented Sep 21, 2019

Hi, thank you for your great BulletinBoard. Unfortunately, this is broken in IOS 13 in Darkmode, since e.g. the date picker is no longer visible, because the background of the bulletin board is not set by .systemBackground (white on white) Can you look at this please? Maybe you can set the backgrounds via .systemBackground and the font by .label.
Thank you and best regards

@DK-Web
Copy link
Author

DK-Web commented Sep 24, 2019

@alexaubry please we need a bugfix! Thx

@alexisakers
Copy link
Owner

Hey! I don’t have the bandwidth to look into this at the moment. If you have a fix, feel free to submit a PR :)

@chrisDeft
Copy link

You can set the backgroundColor property of the BLTN Item Manager to systemBackground - as long as you do this before showing a bulletin it seems to work fine in dark mode.

@aaronbrethorst
Copy link
Contributor

I'm working on this.

@DK-Web
Copy link
Author

DK-Web commented Sep 30, 2019

You can set the backgroundColor property of the BLTN Item Manager to systemBackground - as long as you do this before showing a bulletin it seems to work fine in dark mode.

Hi chrisDeft, a good note thank you!
I solved the problem with
bulletinManager.backgroundColor = .systemBackground

I could also change the font color of the pages like this:

page.appearance.descriptionTextColor = .label
page.appearance.titleTextColor = .label

@DK-Web
Copy link
Author

DK-Web commented Sep 30, 2019

I'm working on this.

Hi aaronbrethorst, thank you for working on it! Best regards

@Danny-SS
Copy link

Danny-SS commented Oct 1, 2019

Thanks @aaronbrethorst! hoping this gets merged

alexisakers pushed a commit that referenced this issue Oct 3, 2019
ghost pushed a commit to mobisecitalia/BulletinBoard that referenced this issue Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants