Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLTNBoard needs dark mode support #53

Closed
aaronbrethorst opened this issue Sep 14, 2019 · 5 comments
Closed

BLTNBoard needs dark mode support #53

aaronbrethorst opened this issue Sep 14, 2019 · 5 comments

Comments

@aaronbrethorst
Copy link
Member

aaronbrethorst commented Sep 14, 2019

I added support to this third party library, and our Carthage version just needs to be bumped to match. Support was added in 4.1.0: https://github.com/alexaubry/BulletinBoard/releases/tag/4.1.0

@aaronbrethorst aaronbrethorst added this to the Launch milestone Sep 16, 2019
@aaronbrethorst aaronbrethorst added Needs Clarification Tasks that additional information before work can begin on them. Blocked and removed Needs Clarification Tasks that additional information before work can begin on them. labels Sep 26, 2019
@alanb2718 alanb2718 self-assigned this Oct 13, 2019
@alanb2718
Copy link
Collaborator

Version 4.1.0 of BulletinBoard seems to be working fine with dark mode. I tested it by setting alarms, which is a use of BulletinBoard in OneBusAway. (Are there other uses to test? I couldn't find any.)

What's the best way to bump the version? Cartfile includes the following:
github "aaronbrethorst/BulletinBoard" "private-deps"
However, this repository doesn't seem to be accessible to me. I just updated the version in Carthage/Checkouts/BulletinBoard to 4.1.0, which works fine although is ignoring the Cartfile command, so doesn't seem like the right thing longer term. So instead I tried changing the line in the Cartfile to github "alexaubry/BulletinBoard" ~> 4.1.0 and then did a carthage update. This also seems to work fine, but changes many files in Carthage/Checkouts since they seem to be lagging behind the current versions.

Also related to #78 (Update 3rd party libraries).

@aaronbrethorst
Copy link
Member Author

Updating the Cartfile with github "alexaubry/BulletinBoard" ~> 4.1.0 and then doing a carthage update is correct. If you want to only want to change BulletinBoard, you can use the command

carthage update BulletinBoard

which is what I would do.

@aaronbrethorst
Copy link
Member Author

(And alarms are the only use of this feature right now, but I'd love to replace the screen that requests location permissions with one of these too)

@alanb2718
Copy link
Collaborator

oops - I was going to have you review the change and merge, but pushed the merge button and ended up doing it. Anyway, the change follows what you suggested.

@aaronbrethorst
Copy link
Member Author

All good and looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants