Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cell barcodes which are longer than 16 nucleotides. #588

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add support for cell barcodes which are longer than 16 nucleotides. #588

merged 1 commit into from
Apr 8, 2019

Commits on Apr 5, 2019

  1. Add support for cell barcodes which are longer than 16 nucleotides. 

    Add support for cell barcodes which are longer than 16 nucleotides.
The old code overwrote the first nucleotides of the cell barcodes
with As for position 1 till (length cell barcode - 16) as cell
barcodes where converted with "convertNuclStrToInt32" and converted
back to "convertNuclInt32toString" and this would cause an overflow.

The number of barcodes is still limited to 2^32 after this patch.
UMIs are still limited to 16 nucleotides. Longer UMIs could be
supported in a similar way.
    @ghuls
    ghuls committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    82e470d View commit details
    Browse the repository at this point in the history