Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mill version, split ivyDeps and compileIvyDeps #70

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Bump mill version, split ivyDeps and compileIvyDeps #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions build.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import de.tobiasroeser.mill.vcs.version._
import mill._, scalalib._, publish._
import mill.scalalib.api.Util.scalaNativeBinaryVersion

val millVersions = Seq("0.9.12", "0.10.12", "0.11.0")
val millVersions = Seq("0.9.12", "0.10.12", "0.11.5")
Copy link

@lefou lefou Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change effectively means, you are no longer supporting Mill 0.11.0 - 0.11.4, as Mill does not guarantee any forward binary compatibilities.

Suggested change
val millVersions = Seq("0.9.12", "0.10.12", "0.11.5")
val millVersions = Seq("0.9.3", "0.10.0", "0.11.0") // scala-steward:off

val millBinaryVersions = millVersions.map(millBinaryVersion)

def millBinaryVersion(millVersion: String) = scalaNativeBinaryVersion(millVersion)
Expand Down Expand Up @@ -47,7 +47,7 @@ trait MillNativeImagePublishModule extends PublishModule {
}

object Scala {
def version = "2.13.6"
def version = "2.13.12"
}

object plugin extends Cross[PluginModule](millBinaryVersions: _*)
Expand All @@ -57,18 +57,20 @@ class PluginModule(millBinaryVersion: String)
def artifactName = s"mill-native-image_mill$millBinaryVersion"
def millSourcePath = super.millSourcePath / os.up
def scalaVersion = Scala.version
def ivyDeps = super.ivyDeps() ++ Agg(
def compileIvyDeps = super.compileIvyDeps() ++ Agg(
ivy"com.lihaoyi::mill-scalalib:${millVersion(millBinaryVersion)}"
)
}

object upload extends ScalaModule with MillNativeImagePublishModule {
def artifactName = "mill-native-image-upload"
def scalaVersion = Scala.version
def ivyDeps = super.ivyDeps() ++ Agg(
def compileIvyDeps = super.compileIvyDeps() ++ Agg(
ivy"com.lihaoyi::os-lib:0.9.1", // beware, not binary compatible with 0.7.x
ivy"com.lihaoyi::ujson:1.4.4",
ivy"com.softwaremill.sttp.client::core:2.3.0",
)
def ivyDeps = super.ivyDeps() ++ Agg(
ivy"com.softwaremill.sttp.client::core:2.3.0"
)
}

Expand Down