Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mill version, split ivyDeps and compileIvyDeps #70

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

carlosedp
Copy link
Collaborator

Fixes #69

@alexarchambault
Copy link
Owner

Thanks for the swift PR, @carlosedp!

@carlosedp carlosedp merged commit 7b5b433 into alexarchambault:master Oct 20, 2023
2 checks passed
@carlosedp carlosedp deleted the fix69 branch October 20, 2023 16:38
@carlosedp
Copy link
Collaborator Author

I've pushed tag 0.1.26 to make a new release

@carlosedp
Copy link
Collaborator Author

@@ -5,7 +5,7 @@ import de.tobiasroeser.mill.vcs.version._
import mill._, scalalib._, publish._
import mill.scalalib.api.Util.scalaNativeBinaryVersion

val millVersions = Seq("0.9.12", "0.10.12", "0.11.0")
val millVersions = Seq("0.9.12", "0.10.12", "0.11.5")
Copy link

@lefou lefou Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change effectively means, you are no longer supporting Mill 0.11.0 - 0.11.4, as Mill does not guarantee any forward binary compatibilities.

Suggested change
val millVersions = Seq("0.9.12", "0.10.12", "0.11.5")
val millVersions = Seq("0.9.3", "0.10.0", "0.11.0") // scala-steward:off

@carlosedp
Copy link
Collaborator Author

Thanks for the tip @lefou ... reverted this on #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mill dependencies should be defined as compileIvyDeps
3 participants