Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redash and update Reanimated #77

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

khevamann
Copy link
Contributor

As I stated in #76 there were issues with my last PR. I hadn't tested it besides running tests and build. My last PR is a safe fix that I have tested. This PR is my attempt to remove redash which is unnecessary now as well as add better reanimated support. I have not tested this yet as the project I am using react-native-skeleton-content is only a minimal example. So I would love a sample project or something to test this branch in more detail. I was a little unsure how to remove loop.

So I would consider this a work-in-progress until I have a little more time to fine tune it

@khevamann khevamann marked this pull request as draft September 19, 2022 16:55
@alexZajac
Copy link
Owner

Hey @khevamann, I don't believe we should switch to yarn, or at least if you believe we should please open a new PR as this is not related to the revert. Ping me when it's green so that we can review it thoroughsly!

@khevamann
Copy link
Contributor Author

@alexZajac Yes this PR is not related to the revert. The other PR is what should currently be merged. This PR is me trying to get reanimated working with the updated version. However I probably won't get around to finishing this until next weekend. Yarn was me trying to test the fix because there was a bug that was apparently npm only. Switching to yarn didn't fix it though, so I will go back to npm. And yes I will ping you when this is ready for review after I find time to test it out

@yepMad
Copy link

yepMad commented Nov 25, 2022

@khevamann Hm... The highlight isn't working for me. Is it working for you?

@khevamann
Copy link
Contributor Author

khevamann commented Nov 26, 2022

@yepMad No, this PR is not completed. I ended up switching to a custom implementation as I am not skilled enough with reanimated to replace all the existing functionality here.

@alexZajac
Copy link
Owner

Hi! Any ETA or ways to unblock the PR on your side?

@jakrim
Copy link

jakrim commented Jan 15, 2023

Looking forward to this resolution -> Can't get my app running with this package currently. Expo at sdk 46

@alexZajac
Copy link
Owner

Hi @khevamann, any progress?

@wmonecke
Copy link

Hey guys! I would love to get this repo up to speed. How can I help getting this to reanimated v3?

Is this still planned?

@marcuzgabriel
Copy link

marcuzgabriel commented Sep 6, 2023

@alexZajac I have made it work with reanimated v3 and react-native-linear-gradient. I can add expo linear gradient package as well and a prop so it is possible to switch between the two if neccessary.

I gladly make a PR for you to review and approve so you can move away from reanimated v1 🚢 .

Alternatively, you can find the update here:
https://www.npmjs.com/package/react-native-reanimated-skeleton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants