Revert update to Reanimated #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR ready? |
|
@alexZajac Yes this PR needs to be merged or there are issues with version 1.0.25 |
|
Merged and published as 1.0.28! |
Is there extra setup needed to use the new version? I tried using it and it just kept giving me the "Reanimated 2 failed to create a worklet" error but I've been able run expo start while using @03balogun's patch. https://www.npmjs.com/package/@03balogun/react-native-skeleton-content |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexZajac Looks like I made a mistake with the last branch I pushed. I didn't realized that between [email protected] and [email protected] they removed all deprecated types. This causes my changes to crash. So I have reverted my upgrade for reanimated while keeping the rest of the dependencies upgraded. I have tested this branch in my project and all works from here.
I am calling this the safe branch and believe it should be released as a fix for the last branch ASAP. See my other branch as well #77