Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rebase checkbox to PR template #162

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Add rebase checkbox to PR template #162

merged 1 commit into from
Nov 6, 2020

Conversation

latacora-tomekr
Copy link
Contributor

@latacora-tomekr latacora-tomekr commented Nov 6, 2020 •
edited
Loading

Motivation

The comment made in #151 (comment)

Changes

Adds a checkbox to the PR template with the text:

Ensured that you have rebased your branch with this repo's latest master branch.

  • Ensured that relevant issues are linked, if this PR resolves any outstanding.
  • Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
  • Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv and *.json files.

@latacora-tomekr latacora-tomekr force-pushed the add-rebase-to-pr-template branch from 0a02505 to d28b139 Compare November 6, 2020 04:49
@bojanrajkovic bojanrajkovic merged commit f81ee6e into alex:master Nov 6, 2020
@khaledhassan khaledhassan mentioned this pull request Nov 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latacora-tomekr @bojanrajkovic