Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continue-on-error true to ignore head/base commit issue #151

Merged

Conversation

latacora-tomekr
Copy link
Contributor

@latacora-tomekr latacora-tomekr commented Nov 6, 2020

Motivation

https://github.com/jitterbit/get-changed-files/blob/master/src/main.ts#L49-L53 checks that head and base match which isn't going to work well with how PR's get opened for this repository. The action still works and correctly displays the modified files so we can add continue-on-error: true to skip this issue.

See also jitterbit/get-changed-files#11

Examples:

Changes

Use continue-on-error: true for the get-changed-files PR step.

  • Ensured that relevant issues are linked, if this PR resolves any outstanding.
  • Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
  • Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv and *.json files.

@bojanrajkovic
Copy link
Collaborator

As discussed, let's close this one and add a "Have you rebased?" checkbox to the PR template.

@bojanrajkovic bojanrajkovic reopened this Nov 6, 2020
@bojanrajkovic bojanrajkovic merged commit d9ee44a into alex:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants