Use new HTTP API to access the database #25
Conversation
database, and the test cases. Tests assume the client now accepts csv replies, but this may be reversed if it's better to just modify the API itself.
to use json result by default. Test pass.
different return formats
There was a problem hiding this comment.
Dejé algunos comentarios específicos en los archivos.
En general me gustó harto que ahora se usen las distintas clases para la respuesta basado en el formato.
Mi mayor temor es en la inicialización de objetos tipo Alerce, porque no me queda claro que todas las opciones vayan a ser respetadas y no vi un test respecto a eso.
…nt into feature/use-api Merged pablo's edits with new commits
|
Files are now Black compliant |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 82.91% 87.02% +4.11%
==========================================
Files 6 7 +1
Lines 316 370 +54
==========================================
+ Hits 262 322 +60
+ Misses 54 48 -6
Continue to review full report at Codecov.
|
…nt into feature/use-api Merge updated tests
Description
Extended the client class to allow for direct querying of the database. Supported output formats are now json, votable, pandas and csv. Test cases were also added.
Related Issue or Feature
Closes #24
Motivation and Context
Direct access to the database was needed, so an HTTP API was developed and this client was updated to use the API.
How Has This Been Tested?
The new unit tests are in tests/test_direct.py. Integration testing with a database with the production schema, has not done yet.