Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Access the database via the HTTP API #24

Closed
ASHuenchuleo opened this issue Nov 18, 2022 · 4 comments · Fixed by #25
Closed

[Feature] Access the database via the HTTP API #24

ASHuenchuleo opened this issue Nov 18, 2022 · 4 comments · Fixed by #25
Assignees
@ASHuenchuleo
Labels
enhancement New feature or request

Comments

@ASHuenchuleo
Copy link
Contributor

An HTTP API that serves as a proxy to the database is being developed. The client must be changed so instead of directly accessing the database it uses the proxy.
@ASHuenchuleo ASHuenchuleo added the enhancement New feature or request label Nov 18, 2022
@ASHuenchuleo ASHuenchuleo self-assigned this Nov 18, 2022
@ASHuenchuleo
Copy link
Contributor Author

ASHuenchuleo commented Nov 18, 2022 •
edited
Loading

The biggest change right now is allowing the client to receive csv replies. This is because, due to JOIN operations, the API does not directly return json due to repeated column names. However the API itself can be modified, getting rid of this problem and keeping JSON hardcoded into the client.

@ASHuenchuleo
Copy link
Contributor Author

The client does not allow for repeated columns, so it must be modified to do so for direct queries

@ASHuenchuleo ASHuenchuleo mentioned this issue Nov 21, 2022
Merged
@ASHuenchuleo ASHuenchuleo linked a pull request Nov 21, 2022 that will close this issue
Use new HTTP API to access the database #25
Merged
@ASHuenchuleo
Copy link
Contributor Author

Integration testing with the actual database schema and a deployed API is yet to be done.

@ASHuenchuleo
Copy link
Contributor Author

Associated PR #25

@ASHuenchuleo ASHuenchuleo changed the title [Feature] Acess the database via the HTTP API [Feature] Access the database via the HTTP API Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ASHuenchuleo ASHuenchuleo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new HTTP API to access the database alercebroker/alerce_client
1 participant
@ASHuenchuleo