Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set background color of bookmarked lines #44

Conversation

ibraimgm
Copy link
Contributor

The option decorateWholeLine, when true, paints the entire line of the color specified by lineDecoratorColor. The default color is a softer version of the bookmark icon color.

Take a look:
bookmark-background

@Rah1x
Copy link

Rah1x commented Oct 18, 2018

Awesome buddy.. did you already merge and release the work? Cause on vscode the last version ive got is [0.12.0] - 2018-09-14.

@ibraimgm
Copy link
Contributor Author

@Rah1x Nope, just sent the PR. Now we need to wait for @alefragnani to review the work and, if it is good enough, do the merge.

@alefragnani alefragnani self-assigned this Oct 30, 2018
@alefragnani
Copy link
Owner

Hi @ibraimgm ,

Thank you for another PR. It will be really useful 👍

I just remembered there is another PR for the same request for my other Bookmarks extension alefragnani/vscode-bookmarks#133. I still didn't merge that (other priorities) but I want to start merging all PRs (including yours) starting next week.

Both PRs use a different approaches and, I think you could simplify this one, if you use just one setting, called backgroundLineColor (instead of lineDecoratorColor). If empty, it means no background color.

Could you update your PR with this idea? I will try to release an extension's update in the next week.

Thank you

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ibraimgm ibraimgm force-pushed the feature/background-for-bookmarked-lines branch from 10f8943 to bc7d385 Compare October 31, 2018 18:04
@ibraimgm
Copy link
Contributor Author

Done!

@alefragnani alefragnani merged commit bc7d385 into alefragnani:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants