Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to define a background line color (Close #98) #133

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Added support to define a background line color (Close #98) #133

merged 1 commit into from
Nov 17, 2018

Conversation

edgardmessias
Copy link
Contributor

Not need reload for change the gutter icon or background color

@alefragnani
Copy link
Owner

Hi @edgardmessias ,

First of all, thanks for your PR.

Right now I'm focusing on others areas in the extension, so you will have to wait a bit prior to merge this request. Please be patience 😃

@alefragnani alefragnani self-assigned this Aug 1, 2018
@edgardmessias
Copy link
Contributor Author

edgardmessias commented Aug 1, 2018 via email

@alefragnani
Copy link
Owner

Hi @edgardmessias ,

Finally coming back to this 😄

I made just one small change. I renamed the setting to backgroundLineColor, to stay equals to my other Numbered Bookmarks extension.

I hope I could release an update this weekend.

Thanks again for your PR 👍

@alefragnani alefragnani merged commit 1e49b21 into alefragnani:master Nov 17, 2018
@geekscrapy
Copy link

Can I ask where this option has been moved to? I dont see it in my settings 👀

@alefragnani
Copy link
Owner

Hi @geekscrapy ,

The bookmarks.backgroundLineColor setting has been deprecated a while ago. The extension now exposes colors which can be defined in workbench.colorCustomizations setting.

It's described here https://github.com/alefragnani/vscode-bookmarks#available-colors

Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants