Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Bookmark position and Debug point #56

Closed
2 tasks done
pankajpatel opened this issue Mar 3, 2017 · 8 comments
Closed
2 tasks done

[Issue] Bookmark position and Debug point #56

pankajpatel opened this issue Mar 3, 2017 · 8 comments
Labels
bug depends on Depends on issues from VS Code question

Comments

@pankajpatel
Copy link

pankajpatel commented Mar 3, 2017

There are two issues that I observed

  • The Bookmark position is not remembered when lines above the bookmark position are added/removed
  • The Debug Icon is not visible because of Bookmark and hence unintentionally user ends up adding/removing debug point.

Though if debug point is present on the line, maybe colour of bookmark icon should change to red or bookmark icon can have a red circle in it.

@alefragnani
Copy link
Owner

Hi @pankajpatel ,

The bookmark position is remembered if you set bookmarks.useStickyBookmarks to true. Today, it is false by default, but I will change that in the near future 😄

About the Debug Icon, it is a VSCode issue, as reported in microsoft/vscode#5923. Unfortunately, there is not ETA for that yet.

Hope this helps

@alefragnani alefragnani added bug depends on Depends on issues from VS Code question labels Mar 5, 2017
@pip182
Copy link

pip182 commented Feb 1, 2018

I have the same or similar problem with the bookmark position changing. After inserting and removing a few lines the bookmark will jump down to the next line. It's especially apparent when you insert some lines and then undo (ctrl+z). I imagine this is a tough issue to fix so I'm just letting you know it's still an issue.

@alefragnani
Copy link
Owner

Hi @pip182 , do you mean you add and remove (Ctrl + Z) a few lines and at some point, the bookmarks becomes out of sync?

@pip182
Copy link

pip182 commented Feb 1, 2018 via email

@alefragnani
Copy link
Owner

I'm closing this issue because the VS Code issue that it depends on, has no update from VS Code team members for almost an year. It is planned on "Backlog" Milestone, but it does not appear to be released soon.

I'm subscribed to that issue, so if/when it is closed, I'll be notified.

@alefragnani
Copy link
Owner

Last week I decided to "re-focus" on some of my extensions, and I'll start to plan milestones for each of them. This "re-focus" will be based on community feedback/support.

@FloatingHero
Copy link

I know this is an old issue, but adding first a breakpoint and the the bookmark works. Hope this helps

@alefragnani
Copy link
Owner

The microsoft/vscode#5923 issue has been resolved, and the current release 1.78 now correctly handles breakpoints and decorators (https://code.visualstudio.com/updates/v1_78#_glyph-margin-decoration-rendering-improvements).

Enjoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug depends on Depends on issues from VS Code question
Projects
None yet
Development

No branches or pull requests

4 participants