Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Bookmarks prevent clicks on breakpoints #551

Closed
shaonianruntu opened this issue Aug 11, 2022 · 5 comments
Closed

[BUG] - Bookmarks prevent clicks on breakpoints #551

shaonianruntu opened this issue Aug 11, 2022 · 5 comments
Labels
bug caused by vscode The issue was caused by a VS Code update duplicate

Comments

@shaonianruntu
Copy link

Environment/version

  • Extension version: 13.3.1
  • VSCode version: 1.70.1
  • OS version: Windows10 21H2 19044.1826

Steps to reproduce

Normally, a click can creates a breakpoint, and clicks the breakpoint again can cancel it.

But when a bookmark is created on the line where the breakpoint is located, the bookmark will overwrite the layer of the breakpoint, and clicking the created breakpoint again cannot cancel it.
You can continue to cancel the breakpoint by clicking only if you unbookmark the current line first.

image

I think it's a bug, bookmarks shouldn't override mouse actions on the current line breakpoint.

Hoping to fix it,

Thanks & Regards
Nan

@shaonianruntu shaonianruntu changed the title [BUG] - [BUG] - Bookmarks prevent clicks on breakpoints Aug 11, 2022
@fade2gray
Copy link
Contributor

You can use the Run -> Toggle Breakpoint from the menu, or use the F9 hotkey.

@alefragnani
Copy link
Owner

Hi @shaonianruntu ,

This issue is caused by VS Code (first reported in #56), and unfortunately, there is nothing I can do on my side. The extension doesn't have any control about the click event. In fact, I wish I had, because I could add a add bookmark with mouse click option 😃

It is being tracked in microsoft/vscode#5923, and besides the original visual issue has been partially solved by VS Code, the click still doesn't.

So, we just have to wait until VS Code itself fixes it, or expose any click event handler to extensions.

Hope this helps

@fade2gray thanks for the tip 👍

@alefragnani alefragnani added caused by vscode The issue was caused by a VS Code update duplicate labels Aug 11, 2022
@shaonianruntu
Copy link
Author

Hi @shaonianruntu ,

This issue is caused by VS Code (first reported in #56), and unfortunately, there is nothing I can do on my side. The extension doesn't have any control about the click event. In fact, I wish I had, because I could add a add bookmark with mouse click option 😃

It is being tracked in microsoft/vscode#5923, and besides the original visual issue has been partially solved by VS Code, the click still doesn't.

So, we just have to wait until VS Code itself fixes it, or expose any click event handler to extensions.

Hope this helps

@fade2gray thanks for the tip 👍

Thank you very much for your detail reply.

Hahaha, I am real confused why we can't add a breakpoint by mouse click before. Seems it is a missing function of VSCode.

Thank you

@sslupsky
Copy link

sslupsky commented Aug 18, 2022

@alefragnani What about the margin on the other side of the line number where the expand / collapse code section controls are located? Can you get a click event there? If that is possible, maybe it is possible to move the bookmark here instead of using the gutter?

@alefragnani
Copy link
Owner

Hi @sslupsky , unfortunately no, it is not possible either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug caused by vscode The issue was caused by a VS Code update duplicate
Projects
None yet
Development

No branches or pull requests

4 participants