Adding get drivers()

[Exoutia]

Description

• I have added the get_drivers function with option to add a round numbers as parameters.
• This function will return the a panda df with name, permanent number, nationality and date of birth column.
• As there is no permanent number before 2014 (according to api documentation) the function will return none in permanent number column if year is less than 2014 in parameter

Related Issue(s)

Fixes #41

Screenshots (If necessary)

for 2014

below 2014

[alec-kr]

Great work 💯
Good catch on that permanent number issue too 😁

Some changes that must be made before merging:

• The table in the README should also be updated to reflect the new function addition. You can add a new row containing the function call, and add a description and returned data type.

• It doesn't seem as though you have added any test for the new function :(
  You should create a test similar to the ones found in /tests.

In /tests, you can create a file called test_get_drivers.py, which will test all methods in DriverInfo. Test data must also be added in /tests/test_data. For the test data, you can use a JSON file containing 3 rows returned from the get_drivers function.

If you have a look at the other tests in the folder, you should get an idea of how the file should be written.

[alec-kr]

Pylint is not happy with some of the code format.

• You must remove the trailing whitespaces from lines 6, 10, 14, 18 and 21 of driver_info.py
• You must also add a class docstring to the DriverInfo class. Great work on adding the other docstrings btw ;)
• There are also a few trailing whitespaces in f1pystats.py at lines 33, 41, 43 and 47.

Your PR should be able to merge after the lint issues, README and method tests have been fixed :)

[Exoutia]

Ok I will do as you pointed out this is my first serious code contribution 😁😁 in open source I will fix them asap

[alec-kr]

Oh wow. Congrats on making your first PR 🎇

[alec-kr]

Great work on fixing the linter issues.

Don't forget to update the README and add your test for the new module. (See my comment, in case you missed it)

[Exoutia]

Great work on fixing the linter issues.

Don't forget to update the README and add your test for the new module. (See my comment, in case you missed it)

I added the test module and updated the read me

[Exoutia]

Sorry for these small mistake I was doing these changes at 1 AM in my timezone so I think i was sleepy 🥲🥲 didn't notice them and in my jupyter note I was mostly relying on auto complete so I didn't find any error during my test run, again sorry I have made those changes as you have suggested.

[alec-kr]

Sorry for these small mistake

It's okay. You can't always get everything right on the first try :)

[alec-kr]

There are some changes that need to be made to pass the Pylint checks:

[Exoutia]

Maintainer works seems very tiring 😢
Still this is important work thanks for doing the hard work 👍

[alec-kr]

Maintainer works seems very tiring

This is the first time I've been maintaining a project. It can be tiring at times.

thanks for doing the hard work

Thank you for contributing 😁

[alec-kr]

Great work! I will merge this shortly