Refactor modules and update code format. (#49) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update tests/ with standardized code format * rm extra newline * update f1pystats/ with standardized code format and more concise function calls * fix bug - add f1pystats.finishing_status * fix lines exceeding 100 char * Removed unnecessary comma * apply timeout kwarg when requesting JSON content * Fixed timeout issue * Changed order of some functions Placed ```_get_json_content_from_url``` at the bottom of the ```f1pystats.py``` file. Co-authored-by: alec-kr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update tests/ with standardized code format
rm extra newline
update f1pystats/ with standardized code format and more concise function calls
fix bug - add f1pystats.finishing_status
fix lines exceeding 100 char
Removed unnecessary comma
apply timeout kwarg when requesting JSON content
Fixed timeout issue
Changed order of some functions
Placed
_get_json_content_from_urlat the bottom of thef1pystats.pyfile.Co-authored-by: alec-kr [email protected]
Description
Related Issue(s)
Fixes #X
User-facing Changes
Screenshots (If necessary)