Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PeerExchangeManager on the right thread #696

Merged
merged 1 commit into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. Handle PeerExchangeManager on the right thread

    Rather than listening to the events, which are asynchronous, just call
    the PeerExchangeManager methods directly when a peer connects or
    disconnects. This ensures the methods are called on the main thread.
    
    Probably fixes the issue where null reference exceptions are thrown when
    encoding peers in a peer exchange message.
    
    One codepath/thread probably added/removed peers from the list and
    another thread did the same. This left things out of sync.
    alanmcgovern committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ca5f216 View commit details
    Browse the repository at this point in the history