Handle PeerExchangeManager on the right thread #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than listening to the events, which are asynchronous, just call the PeerExchangeManager methods directly when a peer connects or disconnects. This ensures the methods are called on the main thread. Probably fixes the issue where null reference exceptions are thrown when encoding peers in a peer exchange message. One codepath/thread probably added/removed peers from the list and another thread did the same. This left things out of sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than listening to the events, which are asynchronous, just call the PeerExchangeManager methods directly when a peer connects or disconnects. This ensures the methods are called on the main thread.
Probably fixes #695, where null reference exceptions are thrown when encoding peers in a peer exchange message.
One codepath/thread probably added/removed peers from the list and another thread did the same. This left things out of sync.