Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in flow declare module parsing #359

Merged
merged 1 commit into from
Nov 25, 2018

Conversation

alangpierce
Copy link
Owner

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #359 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   79.15%   79.24%   +0.08%     
==========================================
  Files          44       44              
  Lines        5066     4847     -219     
  Branches     1133     1133              
==========================================
- Hits         4010     3841     -169     
+ Misses        759      706      -53     
- Partials      297      300       +3
Impacted Files Coverage Δ
src/parser/plugins/flow.ts 63.72% <100%> (+2.97%) ⬆️
src/util/getNonTypeIdentifiers.ts 75% <0%> (-25%) ⬇️
src/parser/index.ts 77.77% <0%> (-7.94%) ⬇️
src/index.ts 82.85% <0%> (-6.51%) ⬇️
src/computeSourceMap.ts 83.33% <0%> (-5.56%) ⬇️
src/parser/plugins/types.ts 90% <0%> (-4.45%) ⬇️
src/util/getTSImportedNames.ts 76.31% <0%> (-4.18%) ⬇️
src/parser/tokenizer/readWord.ts 81.81% <0%> (-3.19%) ⬇️
src/parser/traverser/util.ts 86.2% <0%> (-2.17%) ⬇️
src/parser/traverser/base.ts 95.45% <0%> (-1.69%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196f86e...45cc0d7. Read the comment docs.

@alangpierce alangpierce merged commit bc08f05 into master Nov 25, 2018
@alangpierce alangpierce deleted the fix-declare-module-loop branch November 25, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants