Fix infinite loop in flow declare module parsing (#359)

alangpierce · Nov 25, 2018 · bc08f05 · bc08f05
1 parent 196f86e
commit bc08f05
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/parser/plugins/flow.ts b/src/parser/plugins/flow.ts
@@ -152,6 +152,8 @@ function flowParseDeclareModule(): void {
     if (match(tt._import)) {
       next();
       parseImport();
+    } else {
+      unexpected();
     }
   }
   expect(tt.braceR);

diff --git a/test/flow-test.ts b/test/flow-test.ts
@@ -1,3 +1,5 @@
+import {throws} from "assert";
+import {transform} from "../src";
 import {IMPORT_DEFAULT_PREFIX} from "./prefixes";
 import {assertResult} from "./util";
 
@@ -390,4 +392,19 @@ describe("transform flow", () => {
     `,
     );
   });
+
+  it("does not infinite loop on declare module declarations", () => {
+    throws(
+      () =>
+        transform(
+          `
+      declare module 'ReactFeatureFlags' {
+        declare module.exports: any;
+      }
+    `,
+          {transforms: ["flow"]},
+        ),
+      /SyntaxError: Unexpected token \(3:9\)/,
+    );
+  });
 });