Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular Packages 2.0.0-rc.5 #171

Closed
abnersouzarocket opened this issue Aug 20, 2016 · 22 comments
Closed

Update Angular Packages 2.0.0-rc.5 #171

abnersouzarocket opened this issue Aug 20, 2016 · 22 comments
Milestone

Comments

@abnersouzarocket
Copy link

  • I'm submitting a ...
    [ ] bug report
    [x ] feature request
    [ ] question about the decisions made in the repository
  • Do you want to request a feature or report a bug?
    Update the angular packages to the latest 2.0.0-rc.5, the main reason for that is to be able to use @NgModule decorator

Tried myself but no success, once I run npm start webpack doesn't compile.

Thanks

@bnayalivne
Copy link

bnayalivne commented Aug 21, 2016

I was able to update it but some deps libraries are still not supporting rc5,
for example ng2-bootstrap

@abnersouzarocket
Copy link
Author

@bnayalivne I've aso notice that you mentioned about ng2-bootstrap, they still required rc4. After the update were you able to run the project, or due to that ng2-boostrap you were not able as well?

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 22, 2016

Hey Guys, basically we are waiting for the seed repo of this project to complete the update PatrickJS/PatrickJS-starter#843. There is a list of pros and cons you could check out by this link.

@bnayalivne
Copy link

I wasn't able to run it yet... maybe I can get rid of ng2-bootstrap

@abnersouzarocket
Copy link
Author

@bnayalivne Check the ng2-bootstrap repo the guys are almost done with the upgrade to RC5. You can check the filter for the bugs related to rc5 https://github.com/valor-software/ng2-bootstrap/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20rc5

@nnixaa nnixaa mentioned this issue Aug 25, 2016
@nnixaa
Copy link
Collaborator

nnixaa commented Aug 25, 2016

Hey Guys, just wanted to let you know that we started working on rc5 update yesterday and should have it done soon.

@nnixaa nnixaa added this to the v0.5.0 milestone Aug 25, 2016
@nnixaa
Copy link
Collaborator

nnixaa commented Aug 26, 2016

Just pushed a raw version into https://github.com/akveo/ng2-admin/tree/rc5-update.
A full list of changes you can find under this one commit 45e40f9.

This is still work in progress, but you can already assess a number of changes need to be done. Would be awesome if you try the update and let us know if there are any issues.

A couple of things to consider:

  1. We introduced NgaModule - wrapper for all ng2-admin features. At the moment it includes everything (directives, services, configs, etc). But, the important thing is that we are planning to refactor it and divide into smaller modules, so that if you don't need a whole list of features somewhere in your code - you can simply import a smaller part.
  2. Each page section now is a module (Feature Module as per angular documents).
  3. Routes configuration (again :( ) moved from one complete file to modules (page sections) configurations. Thus we just left menu configuration as it were before (in one file), just renamed it into app.menu.ts.
  4. We are planning to continue code refactoring and planning to change component names to follow angular recommendations. Thus we recommend to not import Ba* directives directly and use NgaModule which will encapsulate the changes we are going to make.

@abnersouzarocket
Copy link
Author

@nnixaa That's awesome... thanks a lot. I have changed and create a lot of things in the project try to test it at the moment would be pretty hard. But I will try to duplicate my project and get the raw version. I will let you know how it goes.

Thanks a lot.

@abnersouzarocket
Copy link
Author

I've been testing for couple of hours, so far so good... Thanks a lot, so many changes with introduction of ngModules, but code looks better.

Good stuff. I will wait for the final migration before migrating everything that I've done.

Tks

@jamg44
Copy link

jamg44 commented Aug 29, 2016

Don't know if its related to this issue but when I run the rc5-update branch, the topbar menu layout is broken, screenshot attached
captura de pantalla 2016-08-29 a las 13 39 44

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 29, 2016

Hey @jamg44, could you please provide your browser console output? Thanks.

@jamg44
Copy link

jamg44 commented Aug 29, 2016

of course:

bootstrap 7359666…:50Uncaught Error: Cannot find module "./lib/bootstrap.loader!./no-op.js"webpackMissingModule
@ loader.js:1(anonymous function)
@ loader.js:1__webpack_require__
@ bootstrap 7359666…:50(anonymous function)
@ vendor.browser.ts:24__webpack_require__
@ bootstrap 7359666…:50webpackJsonpCallback
@ bootstrap 7359666…:21(anonymous function)
@ vendor.bundle.js:2

lang.ts:345Angular 2 is running in the development mode. Call enableProdMode() to enable the production mode.

More info: chrome 51, node 4.2.1, npm 3.7.2, on osx

@jamg44
Copy link

jamg44 commented Aug 29, 2016

and found this error when compiling:

ERROR in .//bootstrap-loader/lib/bootstrap.loader.js!.//bootstrap-loader/no-op.js
Module build failed: Error:
Could not find bootstrap version: '3'. Did you install it?
The package is 'bootstrap' for bootstrap v4 and 'bootstrap-sass' for v3.

at Object.module.exports.pitch (/Users/javi/www/panel-3/ng2-admin/node_modules/bootstrap-loader/lib/bootstrap.loader.js:134:11)

@ ./~/bootstrap-loader/loader.js 1:0-44

@bnayalivne
Copy link

@jamg44 make sure you have bootstrap-v4-alpha2 and not alpha3 installed, as bootstrap-loader not supporting a3 currently

@jamg44
Copy link

jamg44 commented Aug 29, 2016

checked, dump of npm list:

npm list --depth=0
[email protected] /Users/javi/www/panel-3/ng2-admin
├── UNMET PEER DEPENDENCY @angular/[email protected]
├── UNMET PEER DEPENDENCY @angular/[email protected]
├── UNMET PEER DEPENDENCY @angular/[email protected]
├── UNMET PEER DEPENDENCY @angular/[email protected]
├── @angular/[email protected]
├── @angular/[email protected]
├── @angular/[email protected]
├── @angular/[email protected]
├── @angular/[email protected] (git://github.com/gdi2290/router-builds.git#e3a67af53fd058de5f48a643b063260dd157363d)
├── @angularclass/[email protected]
├── @angularclass/[email protected]
├── @angularclass/[email protected]
├── @angularclass/[email protected]
├── @angularclass/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── [email protected] (git://github.com/amcharts/amcharts3.git#adfbf0ed59482106768f89d6b959acce6385d905)
├── [email protected] (git://github.com/amcharts/ammap3.git#bf417a235eac61d5f184d5e48f1238d3c814f5c6)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/[email protected], required by [email protected]
npm ERR! peer dep missing: @angular/forms@^0.2.0, required by [email protected]

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 29, 2016

@jamg44 pin the "bootstrap-loader" to "1.0.10" version in your package json:
"bootstrap-loader": "1.0.10"
this should resolve the issue.

Will upload a fix to github now.

@shay972
Copy link

shay972 commented Aug 29, 2016

Is there new installation guide, I was unable to install it, too many missing modules, I tried manually installing one by one (took me hours) still unable to install all modules

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 29, 2016

Hey @shay972, not sure what you mean by 'manually', have you tried pulling the changes from the rc5-update branch and then running 'npm install'?

@shay972
Copy link

shay972 commented Aug 29, 2016

manually means: npm install
I tried the npm install, gave me tons of missing modules

I used RC5 before on different project, so what do you mean pull the changes?

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 29, 2016

@shay972, currently the master branch does not support angular rc.5, migration to rc.5 is in progress at the moment. The work in progress details you could find under this comment #171 (comment).

So at the moment the only way to try rc.5 with ng2-admin before we complete the migration is to 'git pull' the changes from the rc5-update branch, merge them into your working branch (master branch for instance) and run npm install to install new modules.
Let me know if this helps.

@shay972
Copy link

shay972 commented Aug 29, 2016

ok I understand, but I prefer to wait to rc5 branch, better yet using angluar cli, which is working great with RC5

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 30, 2016

We just released 0.5.0 version which includes a beta migration changes. You could check out the details here https://github.com/akveo/ng2-admin/blob/master/CHANGELOG.md#050-2016-08-30. Looking forward to your feedback, if there any bugs - please consider opening a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants