-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Angular Packages 2.0.0-rc.5 #171
Comments
I was able to update it but some deps libraries are still not supporting rc5, |
@bnayalivne I've aso notice that you mentioned about ng2-bootstrap, they still required rc4. After the update were you able to run the project, or due to that ng2-boostrap you were not able as well? |
Hey Guys, basically we are waiting for the seed repo of this project to complete the update PatrickJS/PatrickJS-starter#843. There is a list of pros and cons you could check out by this link. |
I wasn't able to run it yet... maybe I can get rid of ng2-bootstrap |
@bnayalivne Check the ng2-bootstrap repo the guys are almost done with the upgrade to RC5. You can check the filter for the bugs related to rc5 https://github.com/valor-software/ng2-bootstrap/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20rc5 |
Hey Guys, just wanted to let you know that we started working on rc5 update yesterday and should have it done soon. |
Just pushed a raw version into https://github.com/akveo/ng2-admin/tree/rc5-update. This is still work in progress, but you can already assess a number of changes need to be done. Would be awesome if you try the update and let us know if there are any issues. A couple of things to consider:
|
@nnixaa That's awesome... thanks a lot. I have changed and create a lot of things in the project try to test it at the moment would be pretty hard. But I will try to duplicate my project and get the raw version. I will let you know how it goes. Thanks a lot. |
I've been testing for couple of hours, so far so good... Thanks a lot, so many changes with introduction of ngModules, but code looks better. Good stuff. I will wait for the final migration before migrating everything that I've done. Tks |
Hey @jamg44, could you please provide your browser console output? Thanks. |
of course: bootstrap 7359666…:50Uncaught Error: Cannot find module "./lib/bootstrap.loader!./no-op.js"webpackMissingModule lang.ts:345Angular 2 is running in the development mode. Call enableProdMode() to enable the production mode. More info: chrome 51, node 4.2.1, npm 3.7.2, on osx |
and found this error when compiling: ERROR in ./
@ ./~/bootstrap-loader/loader.js 1:0-44 |
@jamg44 make sure you have bootstrap-v4-alpha2 and not alpha3 installed, as bootstrap-loader not supporting a3 currently |
@jamg44 pin the "bootstrap-loader" to "1.0.10" version in your package json: Will upload a fix to github now. |
Is there new installation guide, I was unable to install it, too many missing modules, I tried manually installing one by one (took me hours) still unable to install all modules |
Hey @shay972, not sure what you mean by 'manually', have you tried pulling the changes from the rc5-update branch and then running 'npm install'? |
manually means: npm install I used RC5 before on different project, so what do you mean pull the changes? |
@shay972, currently the master branch does not support angular rc.5, migration to rc.5 is in progress at the moment. The work in progress details you could find under this comment #171 (comment). So at the moment the only way to try rc.5 with ng2-admin before we complete the migration is to 'git pull' the changes from the rc5-update branch, merge them into your working branch (master branch for instance) and run |
ok I understand, but I prefer to wait to rc5 branch, better yet using angluar cli, which is working great with RC5 |
We just released 0.5.0 version which includes a beta migration changes. You could check out the details here https://github.com/akveo/ng2-admin/blob/master/CHANGELOG.md#050-2016-08-30. Looking forward to your feedback, if there any bugs - please consider opening a new issue. |
[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository
Update the angular packages to the latest 2.0.0-rc.5, the main reason for that is to be able to use @NgModule decorator
Tried myself but no success, once I run npm start webpack doesn't compile.
Thanks
The text was updated successfully, but these errors were encountered: