update to rc.5

[PatrickJS]

merge changes from https://github.com/AngularClass/angular2-seed

Angular 2 Seed will be the simple version of this repo. Both will be updated to Webpack 2

[aminebizid]

Great!

[PatrickJS]

I have a simple version of the starter here https://github.com/AngularClass/angular2-seed that's updated to rc.5 it's where I experiment for changes in this repo

[shahmirn]

I tried to use RC5 and ran into an issue with uri.match is not a function, which is caused by _split being called on moduleId by angular, which in the case of webpack is a number.

angular/angular#10595 is a PR created by @mhamel06 to fix the issue.

[PatrickJS]

don't use moduleId in webpack

[shahmirn]

How about dependencies being used in the project that are using moduleId that we have no control over?

[PatrickJS]

@shahmirn are they public deps on github? if so can you give me a link to the repo. You would use a loader to rewrite it and remove the moduleId but I need to create it.

[mhamel06]

sorry not at computer now but I think my issue may have been from the material repo, since I still had the issue after removing my moduleIDs. this is with the latest Ng module version. https://github.com/angular/material2/blob/master/src/components/sidenav/sidenav.ts

I think ensuring that the _split function is only called with the expected type should fix the core issue.

[PatrickJS]

@mhamel06 @shahmirn
ok fixed via
https://github.com/AngularClass/angular2-seed/commit/84aacc18682bbe38631cd3c457d9e90944d6fd0e

[houko]

when rc5 will be updated in this project? @gdi2290 thank you

[snird]

@gdi2290 the seed repo uses webpack 2, is it planned to update this starter repo to webpak 2 as well?

[PatrickJS]

yup this repo will be updated to webpack2 and rc5

[DzmitryShylovich]

eta?

[paralin]

Looking forward to this, if you'd like me or the 100 other people here waiting for this to help, let us know how!

I noticed when trying to update my own project that the hot loading stuff might be a bit ?? with rc5. Because you have to declare all of the components in a single place. Are we going to make multiple modules for a project, maybe? Seems really a lot more complicated than before.

[yuanfeiz]

Agree with @paralin , I also concern that if we're putting all the deps in one place, isn't it break the encapsulation of each component as they might depend on other libs that are not imported.

[ghost]

I'm currently playing with this repo, and I see that using modules changed pretty much everything in the app organization. Hope to see the updated version soon, this is a really good starting point for new apps.

[abierbaum]

Has anyone hacked together a workaround that will allow use with rc5 for existing rc4 applications?

[PatrickJS]

I can work on a webpack loader that will convert code from rc4 to rc5 NgModule

[DzmitryShylovich]

I would prefer to see how we can integrate aot compilation into webpack build process.

[paralin]

In the release notes they said something like "rc4 apps should still work" but they really don't, I don't see how they think it's a good idea to release another rc and just completely nuke the entire workflow everyone had been using, I mean it makes sense in unstable development software but these are release candidates, not alpha or beta versions. And the fact that we have to declare all of our modules at start means we can't shard with webpack anymore, as far as I can tell.

There's a pretty big discussion on this on an issue on the angular repo, I don't have the link right now, but it's possible they will change a lot of these things before rc6.

At the moment I'm a resigned to staying with rc4 until they fix this stuff.

[ghost]

Actually rc5 is made to be compatible with rc4. Anyway my app worked fine after some adjustments, just have to change about everything from bootstrap to the router, enclose components in modules, change the way directives are loaded and it should work.

[fxck]

yup this repo will be updated to webpack2 and rc5

what does it mean exactly? that it will be updated to webpack2 and rc5 at the same time?

[kjartanvalur]

Has anyone forked this and got this to work with rc5 and webpack 2?

[alvipeo]

Do you really think it'll work with Webpack 2? Have you seen their current list of issues? Come on, guys...

[qdouble]

@alvipeo, angular works fine with webpack 2... cli runs on webpack 2 and angular class also has another repo that is running webpack 2

[alvipeo]

Show me the app built with it then, a real one, not the "overly complex" ToDo app.

[qdouble]

@alvipeo I'm using it in my main project. What exactly do you think doesn't work right with it?

[snird]

@alvipeo , this is an open source project, given to everyone here for free. No one has to "prove" anything to you, and there is a way to ask questions nicely.

That said, the tone here is really harsh for some reason, so I just want to say thank you to @gdi2290 and everyone else at "angular class" for the awesome work here.

[paralin]

I had someone argue with me the other day that they were not going to fix a bug in their project that made it not work against Typescript 2.x because "it's bad practice to use pre-release software so im going to force people to use typescript 1.x to make the world a better place."

Getting the same vibe here from @alvipeo .

You use prerelease software when starting a new project because Typescript 2.x, Angular2, etc will soon become stable versions, and I'd rather start off with the latest than have to upgrade later.

[fxck]

@gdi2290 I'm confused, are you not going to update this repo yourself? Are you waiting for something, or you want to leave it to the community? I mean there seem to be quite a few changes in the angular2-seed repo, not only rc5 and webpack2, is that the go-to starter repo from now on?

[PatrickJS]

Sorry for not being more transparent. We're working on big changes for this repo that will improve the experience. The seed repo will be the new place to test out new build designs and hopefully hold everyone over until we're done. For example, the new DLL build system that improves the build by 5-10x by isolating the vendor files to only build once. It would help if the community could help me update this repo in the mean time. What needs to be done is to follow the new designs in the seed repo which uses webpack2 and update this repo with the updated hmr/async/build. I can also update the repo faster if everyone doesn't mind losing some features such as docs and lint

[adarshaj]

I do not mind losing the auxiliary features like docs and lint over rc.5 upgrade.

(leaving this comment here for others interested to do 👍)

[FabioAntunes]

@gdi2290 Thanks for sharing your plans, really appreciate what you and the rest of the members are doing here. You guys simplified my life a lot and I learned a lot from these repos. Keep up the good work.

[mac-bhaird]

This is a great repo, and am glad I've put together something based on it. I'm good with deferring docs and lint, etc. I've done a few tries at moving it forward locally, but I'm new at this Angular 2 and webpack stuff, so haven't had much success.

[houko]

@gdi2290 thank you very much. I have successfully updated to RC5 .

[mac-bhaird]

Awesome!

In the process of updating myself. Ran into the following,

Can't bind to '<attribute>' since it isn't a known property of '<component>'.

The same challenge is referenced in this issue: angular/angular-cli#1644

[dherges]

@qq83387856 can you share some code? maybe a diff what you've changed?

[mac-bhaird]

hmr was fixed in the recent update just by changing the angular router dependency (the only bit I pulled in so far)

[PatrickJS]

alright webpack2, async, hmr are all working now

[fxck]

Great. What's next now @gdi2290? I wonder whether I should wait for that DLL stuff before I start refactoring everything..

[PatrickJS]

DLLs will take some time since I have to deconstruct the config folder and move all of the comments into the type definition file

[shlomiassaf]

@gdi2290 great advanced work!

I wonder if DLL's can be later on used for lazy routes/modules.
In big apps it might be useful.

[PatrickJS]

async load DLLs? ya, it's possible

[fxck]

I tried merging DLL myself. Failed miserably, there are countless typescript errors just by changing configs from js to ts.

Should the config folder be part of exclude in tsconfig or something?

When it's not in exclude, it's complaining about constants being re-declared, even when I'm not requireing the other files those constants are declared at. When it is in exclude, it cannot find require etc..

[PatrickJS]

ya exclude the config folder

[fxck]

What do I do with Cannot find name 'require'. etc. then though? Use imports instead?

[yuanfeiz]

Any plan for the migration guide?

[fxck]

@gdi2290 any update on those dlls? :)

[jshamley]

I had some similar errors and had to remove my typings folder from app root. Hope that helps someone else.