Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not required features #4

Merged
merged 5 commits into from
Dec 28, 2020
Merged

Remove not required features #4

merged 5 commits into from
Dec 28, 2020

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Dec 26, 2020

We do not actually require http1 feature for hyper but need access to Accept and Connection traits.. (which can be available only on http1 / http2 features).

@fanatid
fix clippy warning
ab4492b 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid
remove tokio features
1e99e51 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid
remove hyper features
2f26dea 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid
move features-util to dev-dependencies
6368e18 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid fanatid mentioned this pull request Dec 26, 2020
Merged
akshayknarayan
akshayknarayan reviewed Dec 28, 2020
View reviewed changes
Copy link
Owner

@akshayknarayan akshayknarayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, suggested change will make the tests pass and we can merge after.

Cargo.toml Outdated Show resolved Hide resolved
@akshayknarayan akshayknarayan merged commit 4963b26 into akshayknarayan:master Dec 28, 2020
@fanatid fanatid deleted the remove-features branch December 28, 2020 16:06
@fanatid
Copy link
Contributor Author

fanatid commented Dec 28, 2020

Thanks!
I think it's worth delaying the new release a little before hyperium/hyper#2377 (issue hyperium/hyper#2376) will be merged and released, then we will able remove http1 feature.

@fanatid
Copy link
Contributor Author

fanatid commented Dec 28, 2020 •
edited
Loading

Looks like I was too late, 0.2.1 already arrived 🙃

@akshayknarayan
Copy link
Owner

It is fine, we can release 0.2.2 when the time comes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayknarayan akshayknarayan akshayknarayan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanatid @akshayknarayan