hyper 0.13 -> 0.14, tonic 0.2 -> 1.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayknarayan
requested changes
Dec 25, 2020
amilkov3
force-pushed
the
hyper-0.14-tonic-1.0
branch
2 times, most recently
from
e3290d4 to
a804c95
Compare
|
Totally slipped my mind. Fixed |
amilkov3
force-pushed
the
hyper-0.14-tonic-1.0
branch
from
a804c95 to
72114ac
Compare
|
Great, looks good. Resolves #2 |
fanatid
reviewed
Dec 26, 2020
| hyper = { version = "0.13", features = ["stream"] } | ||
| tokio = { version = "0.2", features = ["uds"] } | ||
| pin-project = "0.4" | ||
| hyper = { version = "0.14", features = ["full"] } |
There was a problem hiding this comment.
Do we really need features = ["full"]?
There was a problem hiding this comment.
I created pull request with removing not required features: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.