Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make transport adapter messages public #6250

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Make transport adapter messages public #6250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c7da70
Make transport adapter messages public so it can be used in Petabridg…
Arkatufus Nov 14, 2022
9eae85d
Update API Verify list
Arkatufus Nov 14, 2022
9556b13
Merge branch 'v1.4' into 1.4/Make_transport_adapter_public
Arkatufus Nov 14, 2022
25690ec
Fixing DocFx complaints
Aaronontheweb Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions src/core/Akka.API.Tests/CoreAPISpec.ApproveRemote.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,58 @@ namespace Akka.Remote.Transport
public FailureInjectorProvider() { }
public Akka.Remote.Transport.Transport Create(Akka.Remote.Transport.Transport wrappedTransport, Akka.Actor.ExtendedActorSystem system) { }
}
public class FailureInjectorTransportAdapter : Akka.Remote.Transport.AbstractTransportAdapter, Akka.Remote.Transport.IAssociationEventListener
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is sufficiently obscure that it's not going to regularly pop-up in end-user code, but still accessible to an extent that tooling like our planned "failure injection" feature for Petabridge.Cmd can still work.

{
public readonly Akka.Actor.ExtendedActorSystem ExtendedActorSystem;
public const string FailureInjectorSchemeIdentifier = "gremlin";
protected int MaximumOverhead;
public FailureInjectorTransportAdapter(Akka.Remote.Transport.Transport wrappedTransport, Akka.Actor.ExtendedActorSystem extendedActorSystem) { }
protected override Akka.Remote.Transport.SchemeAugmenter SchemeAugmenter { get; }
protected override void InterceptAssociate(Akka.Actor.Address remoteAddress, System.Threading.Tasks.TaskCompletionSource<Akka.Remote.Transport.AssociationHandle> statusPromise) { }
protected override System.Threading.Tasks.Task<Akka.Remote.Transport.IAssociationEventListener> InterceptListen(Akka.Actor.Address listenAddress, System.Threading.Tasks.Task<Akka.Remote.Transport.IAssociationEventListener> listenerTask) { }
public override System.Threading.Tasks.Task<bool> ManagementCommand(object message) { }
public void Notify(Akka.Remote.Transport.IAssociationEvent ev) { }
public bool ShouldDropInbound(Akka.Actor.Address remoteAddress, object instance, string debugMessage) { }
public bool ShouldDropOutbound(Akka.Actor.Address remoteAddress, object instance, string debugMessage) { }
public sealed class All
{
public All(Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode mode) { }
public Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode Mode { get; }
}
public sealed class Drop : Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode
{
public Drop(double outboundDropP, double inboundDropP) { }
public double InboundDropP { get; }
public double OutboundDropP { get; }
}
public interface IFailureInjectorCommand { }
public interface IGremlinMode { }
public sealed class One
{
public One(Akka.Actor.Address remoteAddress, Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode mode) { }
public Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode Mode { get; }
public Akka.Actor.Address RemoteAddress { get; }
}
public sealed class PassThru : Akka.Remote.Transport.FailureInjectorTransportAdapter.IGremlinMode
{
public static Akka.Remote.Transport.FailureInjectorTransportAdapter.PassThru Instance { get; }
}
}
public sealed class ForceDisassociate
{
public ForceDisassociate(Akka.Actor.Address address) { }
public Akka.Actor.Address Address { get; }
}
public sealed class ForceDisassociateAck
{
public static Akka.Remote.Transport.ForceDisassociateAck Instance { get; }
}
public sealed class ForceDisassociateExplicitly
{
public ForceDisassociateExplicitly(Akka.Actor.Address address, Akka.Remote.Transport.DisassociateInfo reason) { }
public Akka.Actor.Address Address { get; }
public Akka.Remote.Transport.DisassociateInfo Reason { get; }
}
public interface IAssociationEvent : Akka.Actor.INoSerializationVerificationNeeded { }
public interface IAssociationEventListener
{
Expand Down Expand Up @@ -711,6 +763,16 @@ namespace Akka.Remote.Transport
public ThrottlerProvider() { }
public Akka.Remote.Transport.Transport Create(Akka.Remote.Transport.Transport wrappedTransport, Akka.Actor.ExtendedActorSystem system) { }
}
public sealed class TokenBucket : Akka.Remote.Transport.ThrottleMode
{
public TokenBucket(int capacity, double tokensPerSecond, long nanoTimeOfLastSend, int availableTokens) { }
public override bool Equals(object obj) { }
public override int GetHashCode() { }
public override System.TimeSpan TimeToAvailable(long currentNanoTime, int tokens) { }
public override System.ValueTuple<Akka.Remote.Transport.ThrottleMode, bool> TryConsumeTokens(long nanoTimeOfSend, int tokens) { }
public static bool ==(Akka.Remote.Transport.TokenBucket left, Akka.Remote.Transport.TokenBucket right) { }
public static bool !=(Akka.Remote.Transport.TokenBucket left, Akka.Remote.Transport.TokenBucket right) { }
}
public abstract class Transport
{
protected Transport() { }
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.Remote/Transport/FailureInjectorTransportAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private FailureInjectorException(SerializationInfo info, StreamingContext contex
/// <summary>
/// TBD
/// </summary>
internal class FailureInjectorTransportAdapter : AbstractTransportAdapter, IAssociationEventListener
public class FailureInjectorTransportAdapter : AbstractTransportAdapter, IAssociationEventListener
{
#region Internal message classes

Expand Down
10 changes: 4 additions & 6 deletions src/core/Akka.Remote/Transport/ThrottleTransportAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public override Task<bool> ManagementCommand(object message)
/// <summary>
/// Management command to force disassociation of an address
/// </summary>
internal sealed class ForceDisassociate
public sealed class ForceDisassociate
{
/// <summary>
/// TBD
Expand All @@ -159,7 +159,7 @@ public ForceDisassociate(Address address)
/// <summary>
/// Management command to force disassociation of an address with an explicit error.
/// </summary>
internal sealed class ForceDisassociateExplicitly
public sealed class ForceDisassociateExplicitly
{
/// <summary>
/// TBD
Expand All @@ -186,7 +186,7 @@ public ForceDisassociateExplicitly(Address address, DisassociateInfo reason)
/// <summary>
/// INTERNAL API
/// </summary>
internal sealed class ForceDisassociateAck
public sealed class ForceDisassociateAck
{
private ForceDisassociateAck() { }
// ReSharper disable once InconsistentNaming
Expand Down Expand Up @@ -653,7 +653,7 @@ public override TimeSpan TimeToAvailable(long currentNanoTime, int tokens)
/// <summary>
/// Applies token-bucket throttling to introduce latency to a connection
/// </summary>
sealed class TokenBucket : ThrottleMode
public sealed class TokenBucket : ThrottleMode
{
readonly int _capacity;
readonly double _tokensPerSecond;
Expand Down Expand Up @@ -726,15 +726,13 @@ private bool Equals(TokenBucket other)
&& _availableTokens == other._availableTokens;
}

/// <inheritdoc/>
public override bool Equals(object obj)
{
if (ReferenceEquals(null, obj)) return false;
if (ReferenceEquals(this, obj)) return true;
return obj is TokenBucket && Equals((TokenBucket)obj);
}

/// <inheritdoc/>
public override int GetHashCode()
{
unchecked
Expand Down