Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transport adapter messages public #6250

Merged

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Nov 14, 2022

Prerequisite for https://github.com/petabridge/petabridge.cmd/pull/587

Changes

Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -580,6 +580,58 @@ namespace Akka.Remote.Transport
public FailureInjectorProvider() { }
public Akka.Remote.Transport.Transport Create(Akka.Remote.Transport.Transport wrappedTransport, Akka.Actor.ExtendedActorSystem system) { }
}
public class FailureInjectorTransportAdapter : Akka.Remote.Transport.AbstractTransportAdapter, Akka.Remote.Transport.IAssociationEventListener
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is sufficiently obscure that it's not going to regularly pop-up in end-user code, but still accessible to an extent that tooling like our planned "failure injection" feature for Petabridge.Cmd can still work.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 14, 2022 23:44
@Aaronontheweb Aaronontheweb merged commit e94913c into akkadotnet:v1.4 Nov 15, 2022
@Aaronontheweb Aaronontheweb added this to the 1.4.46 milestone Nov 15, 2022
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Feb 28, 2023
* Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions

* Update API Verify list

* Fixing DocFx complaints

Co-authored-by: Aaron Stannard <[email protected]>
(cherry picked from commit e94913c)
Aaronontheweb pushed a commit that referenced this pull request Feb 28, 2023
* Make transport adapter messages public (#6250)

* Make transport adapter messages public so it can be used in Petabridge.Cmd for testing network disruptions

* Update API Verify list

* Fixing DocFx complaints

Co-authored-by: Aaron Stannard <[email protected]>
(cherry picked from commit e94913c)

* Update API Verify list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants