-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akka.Remote EndpointWriter backoff bugfix #1777
Akka.Remote EndpointWriter backoff bugfix #1777
Conversation
Looks like an API approval check failed |
@@ -132,22 +131,26 @@ public void Enter(TimeSpan timeout, ImmutableList<string> names) | |||
try | |||
{ | |||
var askTimeout = barrierTimeout + Settings.QueryTimeout; | |||
//TODO: Wait? | |||
// Need to force barrier to wait here, so we can pass along a "fail barrier" message in the event | |||
// of a failed operation | |||
_client.Ask(new ToServer<EnterBarrier>(new EnterBarrier(name, barrierTimeout)), askTimeout).Wait(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a wait here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wait is correct - have to wait for the barrier to ACK before we can proceed. Has a timeout though, so it'll only wait up to 3-5 seconds IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if this was in an async method or not
@Aaronontheweb Dont forget to squash your commit ;) |
Fixed issue with PlayerFSM that broke Throttle in MNTK; Added TestConductorSpec cleaned up referential equality inside RemoteWatcher
1ea39bf
to
1e97890
Compare
@annymsMthd yeah, forgot I did make one minor change to the public API... |
@@ -200,6 +200,11 @@ static void Main(string[] args) | |||
//Block until all Sinks have been terminated. | |||
TestRunSystem.WhenTerminated.Wait(TimeSpan.FromMinutes(1)); | |||
|
|||
if (Debugger.IsAttached) | |||
{ | |||
Console.ReadLine(); //block when debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to make it easier to debug multi-node tests when launching them directly from visual studio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use System.Diagnostics.Debugger.Break()
…veryspec *splat* bugs be-gone
Fresh version of #1360 - includes a major Akka.Remote fix already