Akka.Remote EndpointWriter backoff bugfix #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like an API approval check failed |
| @@ -132,22 +131,26 @@ public void Enter(TimeSpan timeout, ImmutableList<string> names) | |||
| try | |||
| { | |||
| var askTimeout = barrierTimeout + Settings.QueryTimeout; | |||
| //TODO: Wait? | |||
| // Need to force barrier to wait here, so we can pass along a "fail barrier" message in the event | |||
| // of a failed operation | |||
| _client.Ask(new ToServer<EnterBarrier>(new EnterBarrier(name, barrierTimeout)), askTimeout).Wait(); | |||
There was a problem hiding this comment.
The wait is correct - have to wait for the barrier to ACK before we can proceed. Has a timeout though, so it'll only wait up to 3-5 seconds IIRC.
There was a problem hiding this comment.
Wasn't sure if this was in an async method or not
|
@Aaronontheweb Dont forget to squash your commit ;) |
Fixed issue with PlayerFSM that broke Throttle in MNTK; Added TestConductorSpec cleaned up referential equality inside RemoteWatcher
Aaronontheweb
force-pushed
the
1244-atttemptsysmsgredeliveryspec
branch
from
1ea39bf
to
1e97890
Compare
|
@annymsMthd yeah, forgot I did make one minor change to the public API... |
| @@ -200,6 +200,11 @@ static void Main(string[] args) | |||
| //Block until all Sinks have been terminated. | |||
| TestRunSystem.WhenTerminated.Wait(TimeSpan.FromMinutes(1)); | |||
|
|
|||
| if (Debugger.IsAttached) | |||
| { | |||
| Console.ReadLine(); //block when debugging | |||
There was a problem hiding this comment.
Added this to make it easier to debug multi-node tests when launching them directly from visual studio.
There was a problem hiding this comment.
You could also use System.Diagnostics.Debugger.Break()
Aaronontheweb
changed the title
Danthar
added a commit
that referenced
this pull request
Mar 11, 2016
…veryspec *splat* bugs be-gone
This was referenced Mar 11, 2016
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fresh version of #1360 - includes a major Akka.Remote fix already