Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported AttemptSysMsgRedeliverySpec from Akka; Fixed MNTK bugs #1360

Conversation

Aaronontheweb
Copy link
Member

Should resolve AttemptSysMsgRedeliverySpec, which now passes.
Fixed issue with PlayerFSM that broke Throttle in MNTK
Moved Helios to single thread in order to preserve message ordering, which has the added benefit of allowing the AkkaProtocolStressSpec to finally work.

Going to look into perf issues with Helios and add a benchmark for it so I can gauge the impact, but having the correct message order over the network is more important than speed.

@Aaronontheweb
Copy link
Member Author

Bah, C6 issues on the build server

@Aaronontheweb Aaronontheweb force-pushed the gb-1244-AttemptSysMsgRedeliverySpec branch 2 times, most recently from 4a194f7 to 2f74e2e Compare October 5, 2015 23:08
@Aaronontheweb
Copy link
Member Author

@GraemeBradbury looking at the logs, it appears as though AttemptSysMsgRedeliverySpec really did expose an issue with the re-delivery of system messages!

attempt-sys-message-redelivery-spec.txt

@Aaronontheweb
Copy link
Member Author

@GraemeBradbury although, looking at it more closely, could be an issue with turning off black-holing

@Aaronontheweb
Copy link
Member Author

Even more complete logs:
multinode-output.txt

@Aaronontheweb
Copy link
Member Author

Looks to me like the throttling system isn't ever able to turn itself off - either that or there's an issue where the Watch message that is being redelivered never gets ACKed so the Terminated message right behind it never gets delivered either.

Fixed issue with PlayerFSM that broke Throttle in MNTK; moved Helios to single thread
in order to preserve message ordering.
@Aaronontheweb Aaronontheweb force-pushed the gb-1244-AttemptSysMsgRedeliverySpec branch from e6abd6e to 40e24fa Compare January 12, 2016 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant