Ported AttemptSysMsgRedeliverySpec from Akka; Fixed MNTK bugs #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bah, C6 issues on the build server |
Aaronontheweb
force-pushed
the
gb-1244-AttemptSysMsgRedeliverySpec
branch
2 times, most recently
from
4a194f7
to
2f74e2e
Compare
|
@GraemeBradbury looking at the logs, it appears as though |
|
@GraemeBradbury although, looking at it more closely, could be an issue with turning off black-holing |
|
Even more complete logs: |
|
Looks to me like the throttling system isn't ever able to turn itself off - either that or there's an issue where the |
Aaronontheweb
force-pushed
the
gb-1244-AttemptSysMsgRedeliverySpec
branch
from
2f74e2e
to
e6abd6e
Compare
Fixed issue with PlayerFSM that broke Throttle in MNTK; moved Helios to single thread in order to preserve message ordering.
Aaronontheweb
force-pushed
the
gb-1244-AttemptSysMsgRedeliverySpec
branch
from
e6abd6e
to
40e24fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve
AttemptSysMsgRedeliverySpec, which now passes.Fixed issue with PlayerFSM that broke Throttle in MNTK
Moved Helios to single thread in order to preserve message ordering, which has the added benefit of allowing the
AkkaProtocolStressSpecto finally work.Going to look into perf issues with Helios and add a benchmark for it so I can gauge the impact, but having the correct message order over the network is more important than speed.