Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use silencer scalac params when running doc task #2077

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

seglo
Copy link
Contributor

@seglo seglo commented Jan 7, 2020

Purpose

The travis build fails when publishing artifacts for google-cloud-pub-sub because the doc task doesn't have the silencer plugin in scope. For some reason this is only an issue in the 2.12 and 2.13 cross builds.

Ex)

[error] (google-cloud-pub-sub-grpc / Compile / doc) Scaladoc generation failed

https://travis-ci.com/akka/alpakka/jobs/273152362#L1611
https://travis-ci.com/akka/alpakka/jobs/273152363#L2199

References

Changes

  • Only apply silencer scalac parameters in Compile, compile targets.

@seglo seglo added this to the 2.0.0 milestone Jan 7, 2020
@seglo seglo requested a review from ennru January 7, 2020 18:24
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

build.sbt Outdated Show resolved Hide resolved
@seglo
Copy link
Contributor Author

seglo commented Jan 8, 2020

Qualifying the scope to Compile will skip applying the parameter for Test scope. Instead, I've added a filter to remove the parameter when running the doc task, as mentioned in ghik/silencer#40 .

@seglo seglo changed the title Use silencer scalac params in compile scope only Do not use silencer scalac params when running doc task Jan 8, 2020
@seglo seglo merged commit f420069 into akka:master Jan 8, 2020
@seglo seglo deleted the seglo/use-silence-in-compile-scope-only branch January 8, 2020 18:49
@seglo
Copy link
Contributor Author

seglo commented Jan 8, 2020

After I merged I found that this can be simplified by omitting the intask (compile) part of the scoping.

Compile / scalacOptions += "-P:silencer:pathFilters=src_managed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants