Google Cloud Pub/Sub gRPC: latest versions #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
|
Added some instructions in response to #1255 |
raboof
approved these changes
Dec 19, 2019
| @@ -305,6 +308,7 @@ lazy val docs = project | |||
| "extref.akka-http.base_url" -> s"https://doc.akka.io/docs/akka-http/${Dependencies.AkkaHttpBinaryVersion}/%s", | |||
| "scaladoc.akka.http.base_url" -> s"https://doc.akka.io/api/akka-http/${Dependencies.AkkaHttpBinaryVersion}/", | |||
| "javadoc.akka.http.base_url" -> s"https://doc.akka.io/japi/akka-http/${Dependencies.AkkaHttpBinaryVersion}/", | |||
| "extref.akka-grpc.base_url" -> s"https://doc.akka.io/docs/akka-grpc/current/%s", | |||
There was a problem hiding this comment.
(not sure this is worth it if we're only using it in 2 places, but OK)
|
|
||
| ### Maven | ||
|
|
||
| Configure your project to use the Java agent for ALPN and add `-javaagent:...` to your startup scripts as described in the @extref:[Akka gRPC documentation](akka-grpc:/buildtools/maven.html#starting-your-akka-grpc-server-from-maven). |
There was a problem hiding this comment.
I think this is only needed on JDK's 8 and earlier - we should double-check and update the Akka gRPC docs to make this clear as well.
There was a problem hiding this comment.
That's right, I've heard that before... please let me know when you confirmed it.
There was a problem hiding this comment.
I just confirmed it with the Java akka-grpc-quickstart, added akka/akka-grpc#772
|
Something goes bananas with during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use the current versions of Akka gRPC and other dependencies.
References
https://github.com/akka/akka-grpc/releases/tag/v0.7.3