SSE: Allow provision of custom EventStreamUnmarshalling in EventSource #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
changed the title
hseeberger
suggested changes
Sep 4, 2018
There was a problem hiding this comment.
@Synesso thanks for the great analysis and this PR. While from the sole perspective of Alpakka this might be the right approach, I think the original authors of SSE support for Akka HTTP (Gosh, these were me!) should not have (pseudo) hard coded the limit, but instead made it configurable: if we had an easy way of having a configuration setting like akka.http.sse.max-event-size then both Akka HTTP and Alpakka could benefit from that. WDYT?
(Requesting changes in order to further discuss)
|
@hseeberger That sounds perfect. Both |
|
I agree that it should be fixed in Akka HTTP and will review over there, thanks for the help @Synesso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1183 describes how events that exceed line length of 4096 bytes silently fail, leading to a retry loop.
This PR allows the user to provide their own
EventStreamUnmarshallinginstance, thereby overriding the default values formaxEventSizeandmaxLineSize.It does not fix the silent failure, but allows users to avoid it.