Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide configuration settings for client SSE limits #2193

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Provide configuration settings for client SSE limits #2193

merged 2 commits into from
Jan 29, 2019

Conversation

Synesso
Copy link
Contributor

@Synesso Synesso commented Sep 4, 2018 •
edited
Loading

This refers to akka/alpakka#1185 (review) wherein @hseeberger suggested client ServerSentEvent configuration be exposed in akka-http.

Configuration added:

  • akka.http.sse.max-event-size = 8192
  • akka.http.sse.max-line-size = 4096

@akka-ci
Copy link

akka-ci commented Sep 4, 2018

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@Synesso
Copy link
Contributor Author

Synesso commented Sep 5, 2018

Mima check failing because of the need to pass system into what was previously a no-args method.

Should I add a DirectMissingMethodProblem exclusion?

@ktoso
Copy link
Member

ktoso commented Sep 5, 2018

OK TO TEST

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Sep 5, 2018
@akka-ci
Copy link

akka-ci commented Sep 5, 2018

Test FAILed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Sep 5, 2018
@akka-ci
Copy link

akka-ci commented Sep 5, 2018

Test FAILed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Sep 5, 2018
@akka-ci
Copy link

akka-ci commented Sep 5, 2018

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Sep 5, 2018
@akka-ci
Copy link

akka-ci commented Sep 5, 2018

Test PASSed.

@Synesso Synesso force-pushed the jem.mawson/sse-configuration branch from 2f56d38 to 25da5d5 Compare September 5, 2018 12:25
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins labels Sep 5, 2018
@akka-ci
Copy link

akka-ci commented Sep 5, 2018

Test FAILed.

@Synesso Synesso force-pushed the jem.mawson/sse-configuration branch from 25da5d5 to a58a67a Compare September 5, 2018 12:28
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Sep 5, 2018
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jan 19, 2019
@akka-ci
Copy link

akka-ci commented Jan 19, 2019

Test FAILed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jan 19, 2019
@akka-ci
Copy link

akka-ci commented Jan 19, 2019

Test PASSed.

@Synesso
Copy link
Contributor Author

Synesso commented Jan 19, 2019

Thanks @jrudolph. Is 1422c4c what you had in mind?

@jrudolph jrudolph force-pushed the jem.mawson/sse-configuration branch from 1422c4c to 4d11520 Compare January 29, 2019 11:15
jrudolph
jrudolph approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Synesso. LGTM

I squashed the changes together into two commits, one with the syntax changes and one with the actual changes.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jan 29, 2019
@akka-ci
Copy link

akka-ci commented Jan 29, 2019

Test FAILed.

@jrudolph
Copy link
Member

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jan 29, 2019
@akka-ci
Copy link

akka-ci commented Jan 29, 2019

Test PASSed.

@jrudolph jrudolph merged commit c733ab4 into akka:master Jan 29, 2019
@jrudolph jrudolph added this to the 10.1.8 milestone Jan 29, 2019
ennru added a commit to ennru/alpakka that referenced this pull request Jun 19, 2019
@ennru
SSE: Akka HTTP change, make actor system available to reach settings a…
7681816 
…kka/akka-http#2193
ennru added a commit to ennru/alpakka that referenced this pull request Jun 19, 2019
@ennru
SSE: Akka HTTP change, make actor system available to reach settings a…
e941f91 
…kka/akka-http#2193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m left review comments

@raboof raboof raboof left review comments

@hseeberger hseeberger hseeberger requested changes

@ktoso ktoso ktoso approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees

@jrudolph jrudolph

@Synesso Synesso

Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.8
Development

Successfully merging this pull request may close these issues.
8 participants
@Synesso @akka-ci @ktoso @lightbend-cla-validator @jrudolph @raboof @hseeberger @2m