-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export play-grpc to the play org #474
Conversation
This code has been exported out of the akka-grpc repository into https://github.com/playframework/play-grpc. The last release from this repo was: com.lightbend.akka.grpc : akka-grpc-play-testkit : 0.4.2 This is now available from the play-grpc repo as: com.lightbend.play : play-grpc-testkit : 0.5.0-M5 (Still need to sync it from JCenter to Maven Central.) ... and I just realised that I need to change the package from akka.grpc.play to something else... Will do!
Need to fix the docs:
|
Hmm, @raboof should the play interop projects live here or in play-grpc? |
@dwijnand I think it makes sense to have them in play-grpc, WDYT? |
@raboof are My goal is trying to figure out how to land this PR ASAP, and it's broken due to snippets that I removed. |
Eventually I think it'd be neat if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this side this looks good of course ;).
Curious how an example play+akka-grpc app now looks like, but from https://github.com/playframework/play-grpc/blob/master/docs/src/main/paradox/play-framework.md that looks pretty straightforward. Nice!
* Support for @ref[sbt](buildtools/sbt.md), @ref[gradle](buildtools/gradle.md), and @ref[Maven](buildtools/maven.md), | ||
and the @ref[Play Framework](play-framework.md). | ||
and the [Play Framework](https://github.com/playframework/play-grpc/blob/docs/docs/src/main/paradox/play-framework.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somehow feel this should be more prominent, but no specific suggestions, so OK for now.
Co-Authored-By: dwijnand <[email protected]>
Next steps from here is updating the quickstarts. |
This code has been exported out of the akka-grpc repository into
https://github.com/playframework/play-grpc.
The last release from this repo was:
This is now available from the play-grpc repo as:
(Still need to sync it from JCenter to Maven Central.)
... and I just realised that I need to change the package from
akka.grpc.play to something else... Will do!
Tracked as playframework/play-grpc#12
Fixes #362
Fixes #300