Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export play-grpc to the play org #474

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Export play-grpc to the play org #474

merged 3 commits into from
Dec 9, 2018

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Dec 3, 2018

This code has been exported out of the akka-grpc repository into
https://github.com/playframework/play-grpc.

The last release from this repo was:

com.lightbend.akka.grpc : akka-grpc-play-testkit : 0.4.2

This is now available from the play-grpc repo as:

com.lightbend.play : play-grpc-testkit : 0.5.0-M5

(Still need to sync it from JCenter to Maven Central.)

... and I just realised that I need to change the package from
akka.grpc.play to something else... Will do!

Tracked as playframework/play-grpc#12

Fixes #362
Fixes #300

This code has been exported out of the akka-grpc repository into
https://github.com/playframework/play-grpc.

The last release from this repo was:

    com.lightbend.akka.grpc : akka-grpc-play-testkit : 0.4.2

This is now available from the play-grpc repo as:

    com.lightbend.play : play-grpc-testkit : 0.5.0-M5

(Still need to sync it from JCenter to Maven Central.)

... and I just realised that I need to change the package from
akka.grpc.play to something else... Will do!
@dwijnand
Copy link
Member Author

dwijnand commented Dec 3, 2018

Need to fix the docs:

Error writing content for page play-framework.html: Unknown snippet [/localhome/jenkinsakka/workspace/akka-grpc-pr-validator/play-interop-test-scala/src/main/protobuf/helloworld.proto (No such file or directory)] referenced from [play-framework.html]

@dwijnand dwijnand self-assigned this Dec 3, 2018
@dwijnand
Copy link
Member Author

dwijnand commented Dec 3, 2018

Hmm, @raboof should the play interop projects live here or in play-grpc?

@raboof
Copy link
Contributor

raboof commented Dec 4, 2018

@dwijnand I think it makes sense to have them in play-grpc, WDYT?

@dwijnand
Copy link
Member Author

dwijnand commented Dec 4, 2018

@raboof are PlayScalaClientCodeGenerator and friends staying here?

My goal is trying to figure out how to land this PR ASAP, and it's broken due to snippets that I removed.

@raboof
Copy link
Contributor

raboof commented Dec 4, 2018

Eventually I think it'd be neat if PlayScalaClientCodeGenerator moved to play-grpc as well, since you'd expect the akka-grpc API's to stabilize and want to evolve the Play codegen along with the other play tools. I would be fine with postponing that work if it makes it easier to make smaller increments, though.

@raboof raboof mentioned this pull request Dec 4, 2018
@dwijnand dwijnand removed their assignment Dec 4, 2018
@dwijnand dwijnand requested a review from raboof December 4, 2018 18:02
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this side this looks good of course ;).

Curious how an example play+akka-grpc app now looks like, but from https://github.com/playframework/play-grpc/blob/master/docs/src/main/paradox/play-framework.md that looks pretty straightforward. Nice!

docs/src/main/paradox/buildtools/gradle.md Outdated Show resolved Hide resolved
* Support for @ref[sbt](buildtools/sbt.md), @ref[gradle](buildtools/gradle.md), and @ref[Maven](buildtools/maven.md),
and the @ref[Play Framework](play-framework.md).
and the [Play Framework](https://github.com/playframework/play-grpc/blob/docs/docs/src/main/paradox/play-framework.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow feel this should be more prominent, but no specific suggestions, so OK for now.

@dwijnand
Copy link
Member Author

dwijnand commented Dec 5, 2018

Next steps from here is updating the quickstarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants