Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Play gRPC tests into Play repos #362

Closed
richdougherty opened this issue Aug 21, 2018 · 9 comments · Fixed by playframework/playframework#8681
Closed

Move Play gRPC tests into Play repos #362

richdougherty opened this issue Aug 21, 2018 · 9 comments · Fixed by playframework/playframework#8681
Assignees
Labels
play issues regarding play interoperability review
Milestone

Comments

@richdougherty
Copy link
Contributor

Once we're happy that the test APIs created in #356 and #361 are stable we'll want to move these tests into Play repositories. Some code will be moved into playframework/playframework, some into playframework/scalatestplus-play and some could move into a new repository like playframework/play-grpc. For now we can leave the code in the akka-grpc repository, since it's easier to develop it within a single repository.

@richdougherty
Copy link
Contributor Author

Note that PR #356 adds some notes in the source that should be addressed when working on this issue. The notes from me are tagged // RICH:, so a grep should find them.

See: #356 (comment)

@raboof
Copy link
Member

raboof commented Oct 8, 2018

(reopened since automatically closed, probably we can remove some code from this repo once the next version of play is released?)

@dwijnand
Copy link
Member

dwijnand commented Oct 8, 2018

Closing was intentional. But I'm happy to track the removal here with this. 👍

@dwijnand dwijnand added ready and removed review labels Oct 8, 2018
@ignasi35
Copy link
Contributor

ignasi35 commented Oct 8, 2018

TIL GitHub will handle cross-project (cross-organization) PR-related events on issues.

@dwijnand dwijnand added in progress and removed ready labels Oct 9, 2018
@dwijnand
Copy link
Member

dwijnand commented Oct 9, 2018

Provided you have write permission to the issue, yes.

@dwijnand
Copy link
Member

Once Play 2.7 M4 is out this can be finished off.

@dwijnand dwijnand removed their assignment Oct 15, 2018
@dwijnand
Copy link
Member

With playframework/scalatestplus-play#123 merged, this is blocked on a fresh cut of scalatestplus-play.

@dwijnand dwijnand removed the ready label Oct 18, 2018
@dwijnand
Copy link
Member

With #439 merged, this is now blocked on a fresh cut of akka-grpc.

@dwijnand
Copy link
Member

some could move into a new repository like playframework/play-grpc

This is the last step. Move everything to do with Play out of this repo, into play-grpc, including play-interop-test-java, play-interop-test-scala, generators and any other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
play issues regarding play interoperability review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants