-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Play gRPC tests into Play repos #362
Move Play gRPC tests into Play repos #362
Comments
Note that PR #356 adds some notes in the source that should be addressed when working on this issue. The notes from me are tagged See: #356 (comment) |
(reopened since automatically closed, probably we can remove some code from this repo once the next version of play is released?) |
Closing was intentional. But I'm happy to track the removal here with this. 👍 |
TIL GitHub will handle cross-project (cross-organization) PR-related events on issues. |
Provided you have write permission to the issue, yes. |
Once Play 2.7 M4 is out this can be finished off. |
With playframework/scalatestplus-play#123 merged, this is blocked on a fresh cut of scalatestplus-play. |
With #439 merged, this is now blocked on a fresh cut of akka-grpc. |
This is the last step. Move everything to do with Play out of this repo, into play-grpc, including play-interop-test-java, play-interop-test-scala, generators and any other tests. |
Once we're happy that the test APIs created in #356 and #361 are stable we'll want to move these tests into Play repositories. Some code will be moved into playframework/playframework, some into playframework/scalatestplus-play and some could move into a new repository like playframework/play-grpc. For now we can leave the code in the akka-grpc repository, since it's easier to develop it within a single repository.
The text was updated successfully, but these errors were encountered: