Release train #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapatchi
approved these changes
Apr 27, 2020
| response = requests.post(get_chart_location_url, params=query_parameters, headers=header_parameters) | ||
| except Exception as e: | ||
| raise CLIError("Error while fetching helm chart repository path: " + str(e)) | ||
| if response.status_code == 200: |
There was a problem hiding this comment.
nitpick: Do you want to retry the config dp call in case of 429 (throttling scenario)
There was a problem hiding this comment.
Not expecting throttling for private preview. Hence will not add for this PR.
akashkeshari
pushed a commit
that referenced
this pull request
Aug 13, 2020
* [ConnectedK8s] Added update command (#3) * Removed location parameter as it is taken from cc * Removed tags parameter * renamed --proxy-skip-destinations to --proxy-skip-range Co-authored-by: root <root@anshenoVM.da12rmhqn3xunlrjlf1ytzev1d.bx.internal.cloudapp.net>
akashkeshari
pushed a commit
that referenced
this pull request
Dec 16, 2021
* add appservice-kube extension * Retrieving function triggers from the function image * Retrieving function triggers from the function image * Fix appservice kube list by subscription * Fix transient error when loading arguments * Added az webapp up support * Handled code review comments * bump up version to 0.1.1 * Use custom sdk code for app service plan command sdk * Version 0.1.2 * Private registry image support and fixig windows to unix line feed char issue to retrive triggers from a function app * Removing debugpy.breaspoint() line * Update custom.py Removing trailing white spaces * Update custom.py Removing trailing white spaces * fixing the condition when the image is from the public registry with no user name and password supplied * Update sdk, add BYO AKS cluster to kube create command * Add version 0.1.3 * Copying getfunctionsjson.sh as part of appservice-kube extension and correcting the lookup path * Adding version 0.1.4 * fix * Update version to 0.1.5 * Update kube environments SDK * Add version 0.1.6 * Update kube environments SDK (using api version 2020-06-01), delete old parameters from commands * Add version 0.1.7 * remove azure-cli-core dependency * Add version 0.1.8 * Add latest changes from cli core (except az webapp up) * Bugfix: if ftp deployment profile doesn't exist, zip deploy fails * Bugfix: index.json had weird merge conflict * Bugfix: webapp config container set wasn't setting * Version 0.1.9 * Add functionapp config container set * Start referencing main cli * Functionapp deployment source config-zip command fix (copy over from main CLI for now) * Functions CLI should not pull docker image * Plan creation should drop --kube-environment and --kube-sku * Change kind to 'linux,kubernetes' * Help text changes * Publish extension v 0.1.10 * Version 0.1.11, since broke appservice plan create for non-k8se plans * Allow specifying custom location by name rather than resource ID * az appservice kube create command * Change ASP kind back to K8SE, reserved to None * Publish 0.1.12 whl * az webapp create doesn't require plan for k8se * Change app service plan kind to 'linux,kubernetes' and reserved=true if linux * Webapp create should pass with ASP kind=linux if SKU is a kube sku * az functionapp create without plan * Fix bug where if webapp/functionapp create called to update, if --plan isnt specified it creates new plan * fix webapp/functionapp create, if calling create again with new custom location/plan edge cases * Version 0.1.13 * Version 0.1.14 temporary change to stop doing the list in web/func app creates * Add better help text for appservice create with custom location * Update appservice SDK for kube extension to 2020-12-01 * Clean up az kube create * Update to version 0.1.15 * Fix dotnet5 bug * Converting skus for kubernetes ASPs to the new values * 0.1.16 version * Set number of workers to 1 when creating ASP * Add webapp scale command * Version 0.1.17 with az webapp scale * rename az webapp scale param * Move restart in from main CLI, since api returns 202 rather than 200. Need SDK update * Change SDK to have extended location envelope manually - need to see why generating SDK locally is failing * Pass ExtendedLocationEnvelope to web/functionapp, appservice plan and kube environment creates * Version 0.1.18 * Remove webapp up from extension * Use delete_app_settings function from cli core * Use webapp validator from core CLI * Use updated update_app_settings function from core CLI * 0.1.19 version * Fix regression when using main CLI validators * 0.1.20 version * az appservice kube create: better error message when conflict * Remove vsts_cd_manager * Version 0.1.21 * Update index.json * K8se master kube env create validations (#3) * az kube create: allow using custom location name. Also get location from custom location rather than resource group * Require cli core 2.26.0 or later * Version 0.2.0 * Use ExtendedLocation property ob object level (#4) * Static ip not required property in kube create * Version 0.2.1 * Fix NoneType object has no attribute custom_location error * Bugfix: Wrong custom location being used if multiple custom locations exist in diff rg (#5) * Fix NoneType object has no attribute custom_location error * If two custom locations with same name, in different resource group sometimes it uses wrong custom location * Version 0.2.2 * remove old SDK and start 'az appservice kube' rewrite * rewrite 'az appservice kube show' * rewrite 'az appservice kube list' * rewrite 'az appservice kube delete' * re-add appservice kube create checks and start appservice kube update impl * raise exception for 'az appservice kube update' * add 'az appservice kube wait' * add kube list pagination * fix 'az appservice create' * fix 'az appservice plan update' * fix 'az webapp create' * fix az webapp show/restart * remove 'az webapp config container set' * remove uneeded TODOs * format results of 'az appservice kube show/list' * remove TODOs and fix 'az webapp show -s' * add misc style fixes * fix more style issues * revert src/index.json to master version * add summary * fix linter issues * remove out-of-date test * fix appservice kube CLI linter issues * fix ASP sku validation * fix style * increment appservice-kube release number and fix service_name.json * fix hardcoded 'verify_linter.py' * add testing -- WIP * update codeowners and fix 'az appservice kube list' bug * remove unfinished tests * remove unnecessary branching * remove unnecessary options lists * use specific CLI error types * use more specific error type * fix more error types * use HttpResponseError * fix style * revert version and erase history Co-authored-by: Eben Carek <[email protected]> Co-authored-by: Satish Ranjan <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]> Co-authored-by: Eben Carek <[email protected]> Co-authored-by: SatishRanjan <[email protected]> Co-authored-by: Calvin Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.