Pavan/distro detect #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add aks-custom-headers for nodepool and update add version change add parameters * fix test failure add help
* WIP {KubernetesConfiguration} Add CLI
* Fix Pylint errors
* Added Scenario test and addressed review comments
* Address review comments
* Added to CodeOwners and other fixes
* Fix more errors reported by static tools
* Fix one more error reported by static tool
* Updated the SDK with the official version
* Update src/k8sconfiguration/azext_k8sconfiguration/commands.py
Co-Authored-By: Feiyue Yu <[email protected]>
* Address PR comments
* Updated the sdk files to fix api-version parameter issue
* Update src/k8sconfiguration/azext_k8sconfiguration/custom.py
Co-Authored-By: Xiaojian Xu <[email protected]>
* addressed more comments
* remove Optional from help message
* Remove azure-cli-core dependency
* Pulled new version of sdk, and help text update
* Updated test and other style fixes
* Removed unused import
* Update min Cli core version
* Added revision to the updated minCliCoreVersion
Co-authored-by: nanthi <nanthi@NANTHI01>
Co-authored-by: Feiyue Yu <[email protected]>
Co-authored-by: Xiaojian Xu <[email protected]>
Co-authored-by: Xiaojian Xu <[email protected]>
…#1700) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=392553 Last commit: Azure@df6806d
akashkeshari
pushed a commit
that referenced
this pull request
Feb 8, 2021
* Azure quantum extension v0 (#2) Initial version. * Fixing style issues * Incorporating feedback (#6) * readme * feedback * Help * Make storage account optional (Azure#7) * Storage is now optional (Azure#8) * Making storage an argument, not an env variable (Azure#9) * Adding implementation of 'az quantum workspace delete' command. * Setting new temporary version. * Fixing missing file in test change * Adding details to README.md (#5) * Updating generated files for Azure Quantum resource manager from new swagger file version * Remove manual edit of generated file. * Updating generated files for Azure Quantum data plane from new swagger file version * Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13) * Adding implementation of 'az quantum workspace create' command. (Azure#14) Adding initial implementation of 'az quantum workspace create' command. ----------------------------------- Command az quantum workspace create : Creates a new Azure Quantum workspace. Command group 'quantum' is in preview. It may be changed/removed in a future release. Arguments --location -l : Location. Values from: az account list-locations. You can configure the default location using az configure --defaults location=<location>. --resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>. --storage_account -sa : Name of the storage account to be used by a quantum workspace. --workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace using az quantum workspace set. * Update Azure CLI quantum extension to multi-region (Azure#17) This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command. * Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16) Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. * Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19) Fixing tests for multi-region URL change on Az CLI quantum extension * Incorporating ARM feedback (Azure#18) * Picking up latest changes from swagger after ARM feedback * updated create_or_update * run command * Setting default location in workspace calls if not specified (Azure#20) * updating python azure quantum rest client (Azure#21) * Update generated files from swagger file (Version 2021-01-11) (Azure#22) * Hot fixes on December 2020 release of Azure CLI extension (Azure#23) * Fixing issue with over specification of location * Updating version information of extension * Update CLI with generated clients from more recent swagger files (Azure#24) - Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b. - Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b. * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Require location as a mandatory parameter in workspace specification (Azure#25) * Make location mandatory in commands * Update test recordings * Resetting the version history for the released version. * Fix description of workspace clear command * Updatig Readme file to RST format. * Update Readme file per pull request comments. * Fixing az quantum run and execute commands to include location parameter * Performing role assignment on storage account on workspace creation. (Azure#29) * Add warning message about providers during workspace creation (Azure#30) * Enable command az quantum workspace quotas (Azure#31) * Removing extra space in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Fix punctuation in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/azext_quantum/_params.py Co-authored-by: Feiyue Yu <[email protected]> * First round of code review feedback on Readme.rst * Improve code readability on job commands * Avoid IndexError in case of malformed URL * Extended info on targetId parameter * Add help to each individual command * Reorganize sections in Readme.rst and merge in a single set of instructions. * Static analysis fixes * Fix CLI Linter errors * Fix CLI Linter errors. Part 2 * Fix typo in show command. * Fix show command for Linter * Use standard name for show command method * Modify workspace create test to skip role assignment * Update tests with workspace names used currently. * Update test recordings. * Set subscription for the recordings. * Update test recordings. * Update QDK version number * Remove asserts and checks for subscription * Experiment: Remove check for preview subscription * Refresh recordings with current test values. * Update recordings after typo fix. * Remove commented out API that references subscription * Enable QuantumJobsScenarioTest.test_submit_args only on live mode Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
akashkeshari
pushed a commit
that referenced
this pull request
Dec 16, 2021
* add appservice-kube extension * Retrieving function triggers from the function image * Retrieving function triggers from the function image * Fix appservice kube list by subscription * Fix transient error when loading arguments * Added az webapp up support * Handled code review comments * bump up version to 0.1.1 * Use custom sdk code for app service plan command sdk * Version 0.1.2 * Private registry image support and fixig windows to unix line feed char issue to retrive triggers from a function app * Removing debugpy.breaspoint() line * Update custom.py Removing trailing white spaces * Update custom.py Removing trailing white spaces * fixing the condition when the image is from the public registry with no user name and password supplied * Update sdk, add BYO AKS cluster to kube create command * Add version 0.1.3 * Copying getfunctionsjson.sh as part of appservice-kube extension and correcting the lookup path * Adding version 0.1.4 * fix * Update version to 0.1.5 * Update kube environments SDK * Add version 0.1.6 * Update kube environments SDK (using api version 2020-06-01), delete old parameters from commands * Add version 0.1.7 * remove azure-cli-core dependency * Add version 0.1.8 * Add latest changes from cli core (except az webapp up) * Bugfix: if ftp deployment profile doesn't exist, zip deploy fails * Bugfix: index.json had weird merge conflict * Bugfix: webapp config container set wasn't setting * Version 0.1.9 * Add functionapp config container set * Start referencing main cli * Functionapp deployment source config-zip command fix (copy over from main CLI for now) * Functions CLI should not pull docker image * Plan creation should drop --kube-environment and --kube-sku * Change kind to 'linux,kubernetes' * Help text changes * Publish extension v 0.1.10 * Version 0.1.11, since broke appservice plan create for non-k8se plans * Allow specifying custom location by name rather than resource ID * az appservice kube create command * Change ASP kind back to K8SE, reserved to None * Publish 0.1.12 whl * az webapp create doesn't require plan for k8se * Change app service plan kind to 'linux,kubernetes' and reserved=true if linux * Webapp create should pass with ASP kind=linux if SKU is a kube sku * az functionapp create without plan * Fix bug where if webapp/functionapp create called to update, if --plan isnt specified it creates new plan * fix webapp/functionapp create, if calling create again with new custom location/plan edge cases * Version 0.1.13 * Version 0.1.14 temporary change to stop doing the list in web/func app creates * Add better help text for appservice create with custom location * Update appservice SDK for kube extension to 2020-12-01 * Clean up az kube create * Update to version 0.1.15 * Fix dotnet5 bug * Converting skus for kubernetes ASPs to the new values * 0.1.16 version * Set number of workers to 1 when creating ASP * Add webapp scale command * Version 0.1.17 with az webapp scale * rename az webapp scale param * Move restart in from main CLI, since api returns 202 rather than 200. Need SDK update * Change SDK to have extended location envelope manually - need to see why generating SDK locally is failing * Pass ExtendedLocationEnvelope to web/functionapp, appservice plan and kube environment creates * Version 0.1.18 * Remove webapp up from extension * Use delete_app_settings function from cli core * Use webapp validator from core CLI * Use updated update_app_settings function from core CLI * 0.1.19 version * Fix regression when using main CLI validators * 0.1.20 version * az appservice kube create: better error message when conflict * Remove vsts_cd_manager * Version 0.1.21 * Update index.json * K8se master kube env create validations (#3) * az kube create: allow using custom location name. Also get location from custom location rather than resource group * Require cli core 2.26.0 or later * Version 0.2.0 * Use ExtendedLocation property ob object level (#4) * Static ip not required property in kube create * Version 0.2.1 * Fix NoneType object has no attribute custom_location error * Bugfix: Wrong custom location being used if multiple custom locations exist in diff rg (#5) * Fix NoneType object has no attribute custom_location error * If two custom locations with same name, in different resource group sometimes it uses wrong custom location * Version 0.2.2 * remove old SDK and start 'az appservice kube' rewrite * rewrite 'az appservice kube show' * rewrite 'az appservice kube list' * rewrite 'az appservice kube delete' * re-add appservice kube create checks and start appservice kube update impl * raise exception for 'az appservice kube update' * add 'az appservice kube wait' * add kube list pagination * fix 'az appservice create' * fix 'az appservice plan update' * fix 'az webapp create' * fix az webapp show/restart * remove 'az webapp config container set' * remove uneeded TODOs * format results of 'az appservice kube show/list' * remove TODOs and fix 'az webapp show -s' * add misc style fixes * fix more style issues * revert src/index.json to master version * add summary * fix linter issues * remove out-of-date test * fix appservice kube CLI linter issues * fix ASP sku validation * fix style * increment appservice-kube release number and fix service_name.json * fix hardcoded 'verify_linter.py' * add testing -- WIP * update codeowners and fix 'az appservice kube list' bug * remove unfinished tests * remove unnecessary branching * remove unnecessary options lists * use specific CLI error types * use more specific error type * fix more error types * use HttpResponseError * fix style * revert version and erase history Co-authored-by: Eben Carek <[email protected]> Co-authored-by: Satish Ranjan <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]> Co-authored-by: Eben Carek <[email protected]> Co-authored-by: SatishRanjan <[email protected]> Co-authored-by: Calvin Chan <[email protected]>
akashkeshari
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Use userValues.txt instead of --resuse-values in update command * fix error msg * added custom cert * change setup.py * Helmupdatefix (#4) * Use userValues.txt instead of --resuse-values in update command * fix error msg Co-authored-by: Siri Teja Reddy Kasireddy <[email protected]> * fix output file * Helmupdatefix (#5) * Use userValues.txt instead of --resuse-values in update command * fix error msg * fix output file Co-authored-by: Siri Teja Reddy Kasireddy <[email protected]> * place values file in .azure folder * place values file in .azure folder * Helmupdatefix (#6) * Use userValues.txt instead of --resuse-values in update command * fix error msg * fix output file * place values file in .azure folder * place values file in .azure folder Co-authored-by: Siri Teja Reddy Kasireddy <[email protected]> * place values file in .azure folder * nit * nit * nit * setp.py and history.rst updates * modify the way of fetching userValues.txt path * Waiting for LRO to complete before moving ahead with agent installation/deletion * update history.rst * fix * fix location variable Co-authored-by: Siri Teja Reddy Kasireddy <[email protected]> Co-authored-by: siriteja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.