-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal component #10
Merged
Merged
Modal component #10
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
|
||
|
||
<b>Examples:</b> | ||
|
||
```js | ||
const handleOk = () => { | ||
// do your stuff here | ||
modal.hide() | ||
} | ||
|
||
const handleCancel = () => { | ||
modal.hide() | ||
} | ||
|
||
const showModal = () => { | ||
modal.show( | ||
<Card style={{width: 400}}> | ||
<CardHeader | ||
title="Modals Are Cool" | ||
subtitle="Super-cool" | ||
/> | ||
<CardBody> | ||
This is a modal-card. | ||
</CardBody> | ||
<CardFooter | ||
left={ | ||
<Button onClick={handleCancel}> Cancel </Button> | ||
} | ||
right={ | ||
<Button primary onClick={handleOk}> Ok </Button> | ||
} | ||
/> | ||
</Card> | ||
) | ||
}; | ||
|
||
<div> | ||
<Button onClick={showModal}> Click Here </Button> | ||
<Modal id="unique-id-1" ref={(comp) => modal = comp}/> | ||
</div> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import React, { Component } from 'preact'; | ||
import PropTypes from 'prop-types'; | ||
import { StyledModal } from './styles'; | ||
import ModalPortal from './ModalPortal'; | ||
|
||
/** | ||
* Description | ||
* | ||
* @example ./../../docs/components/Modal.md | ||
*/ | ||
class Modal extends Component { | ||
constructor(props) { | ||
super(props); | ||
this.state = { | ||
content: false, | ||
}; | ||
} | ||
|
||
static propTypes = { | ||
/** | ||
* Custom styles | ||
*/ | ||
style: PropTypes.object, | ||
}; | ||
|
||
static defaultProps = {}; | ||
|
||
static contextTypes = { | ||
theme: PropTypes.object, | ||
}; | ||
|
||
show = content => { | ||
this.setState({ content }); | ||
}; | ||
|
||
hide = () => { | ||
this.setState({ content: false }); | ||
}; | ||
|
||
render() { | ||
const { style = {}, className } = this.props; | ||
const { theme } = this.context; | ||
|
||
return this.state.content ? ( | ||
<ModalPortal> | ||
<StyledModal style={style} className={className} theme={theme}> | ||
{this.state.content} | ||
</StyledModal> | ||
</ModalPortal> | ||
) : null; | ||
} | ||
} | ||
|
||
export default Modal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import React, { Component } from 'preact'; | ||
import PropTypes from 'prop-types'; | ||
import { StyledModalWrapper } from './styles'; | ||
|
||
/** | ||
* Modal Portal Component | ||
*/ | ||
class ModalPortal extends Component { | ||
constructor(props) { | ||
super(props); | ||
this.portal = null; | ||
} | ||
componentDidMount() { | ||
let portal = | ||
this.props.portalId && document.getElementById(this.props.portalId); | ||
if (!portal) { | ||
portal = document.createElement('div'); | ||
portal.id = this.props.portalId; | ||
portal.style.position = 'fixed'; | ||
portal.style[this.props.position] = '0'; | ||
portal.style.top = '0'; | ||
portal.style.left = '0'; | ||
portal.style.width = '100vw'; | ||
portal.style.height = '100vh'; | ||
portal.style.overflow = 'hidden'; | ||
portal.style.display = 'flex'; | ||
portal.style.alignItems = 'center'; | ||
portal.style.justifyContent = 'center'; | ||
portal.style.backgroundColor = 'rgba(0, 0, 0, 0.8)'; | ||
document.body.appendChild(portal); | ||
} | ||
this.portal = portal; | ||
this.componentDidUpdate(); | ||
} | ||
componentWillUnmount() { | ||
const element = document.getElementById(this.props.portalId); | ||
if (element) { | ||
document.body.removeChild(this.portal); | ||
} | ||
} | ||
componentDidUpdate() { | ||
if (!this.props.children.length) { | ||
return; | ||
} | ||
React.render( | ||
<StyledModalWrapper {...this.props}> | ||
{this.props.children} | ||
</StyledModalWrapper>, | ||
this.portal | ||
); | ||
} | ||
render = () => null; | ||
} | ||
|
||
export default ModalPortal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export default from './Modal'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import styled, { css } from 'styled-components'; | ||
import defaultTheme from '../theme'; | ||
|
||
const StyledModal = styled.div` | ||
${props => | ||
props.style && | ||
css` | ||
${props.style}; | ||
`}; | ||
`; | ||
|
||
StyledModal.defaultProps = { | ||
theme: defaultTheme, | ||
}; | ||
|
||
export { StyledModal }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you get props as part of the render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, and I am happy to make the change, but I tried to closely follow the style of
Notify
. Should I add to the PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no its fine.