Modal component #10
Merged
Modal component #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to follow what |
thabti
reviewed
Oct 31, 2018
| }; | ||
|
|
||
| render() { | ||
| const { style = {}, className } = this.props; |
There was a problem hiding this comment.
you get props as part of the render
There was a problem hiding this comment.
render({ style = {}, className }) {
There was a problem hiding this comment.
That makes sense, and I am happy to make the change, but I tried to closely follow the style of Notify. Should I add to the PR?
thabti
approved these changes
Oct 31, 2018
|
Really cool - I will play around with this tonight/tomorrow. |
|
@konsumer Thank you for the contribution :) |
|
@konsumer has been released as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a modal component & docs, that looks like this: